Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1384583003: Revert of Mac Overlays: Clip display and UV rects (Closed)

Created:
5 years, 2 months ago by ccameron
Modified:
5 years, 2 months ago
Reviewers:
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2490
Target Ref:
refs/pending/branch-heads/2490
Project:
chromium
Visibility:
Public.

Description

Revert of Mac Overlays: Clip display and UV rects (patchset #1 id:1 of https://codereview.chromium.org/1381603003/ ) Reason for revert: Breaks compile. Original issue's description: > Mac Overlays: Clip display and UV rects > > Make the Mac-specific sandwich strategy apply clipping to the display > rectangle. Apply the same relative clipping to the uv rectangle. > > Add unit tests, and move code around to improve readability. > > BUG=536854 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Review URL: https://codereview.chromium.org/1370363002 > > Cr-Commit-Position: refs/heads/master@{#351312} > (cherry picked from commit e790d9f582a00168faf0aa81f6fe5477848bec2b) > > Committed: https://chromium.googlesource.com/chromium/src/+/21a4f7e7e56823e74997fb64b57a80bc619506be TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=536854

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -72 lines) Patch
M cc/output/overlay_strategy_common.cc View 2 chunks +1 line, -5 lines 0 comments Download
M cc/output/overlay_strategy_sandwich.cc View 4 chunks +9 lines, -34 lines 0 comments Download
M cc/output/overlay_unittest.cc View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ccameron
Created Revert of Mac Overlays: Clip display and UV rects
5 years, 2 months ago (2015-10-01 22:07:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384583003/1
5 years, 2 months ago (2015-10-01 22:07:49 UTC) #2
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 22:10:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698