Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Issue 1370363002: Mac Overlays: Clip display and UV rects (Closed)

Created:
5 years, 2 months ago by ccameron
Modified:
5 years, 2 months ago
Reviewers:
Andre
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac Overlays: Clip display and UV rects Make the Mac-specific sandwich strategy apply clipping to the display rectangle. Apply the same relative clipping to the uv rectangle. Add unit tests, and move code around to improve readability. BUG=536854 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/e790d9f582a00168faf0aa81f6fe5477848bec2b Cr-Commit-Position: refs/heads/master@{#351312}

Patch Set 1 #

Patch Set 2 : Merge candidate_pixel_rect and display_rect more explicitly #

Total comments: 6

Patch Set 3 : Irf #

Patch Set 4 : irf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -21 lines) Patch
M cc/output/overlay_strategy_common.cc View 4 chunks +4 lines, -12 lines 0 comments Download
M cc/output/overlay_strategy_sandwich.cc View 1 2 3 4 chunks +34 lines, -9 lines 0 comments Download
M cc/output/overlay_unittest.cc View 1 chunk +33 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (5 generated)
ccameron
https://codereview.chromium.org/1370363002/diff/20001/cc/output/overlay_strategy_common.cc File cc/output/overlay_strategy_common.cc (right): https://codereview.chromium.org/1370363002/diff/20001/cc/output/overlay_strategy_common.cc#newcode199 cc/output/overlay_strategy_common.cc:199: draw_quad.shared_quad_state->quad_to_target_transform, draw_quad.rect); Put these two next to each other, ...
5 years, 2 months ago (2015-09-29 00:24:32 UTC) #2
Andre
LGTM https://codereview.chromium.org/1370363002/diff/20001/cc/output/overlay_strategy_sandwich.cc File cc/output/overlay_strategy_sandwich.cc (right): https://codereview.chromium.org/1370363002/diff/20001/cc/output/overlay_strategy_sandwich.cc#newcode23 cc/output/overlay_strategy_sandwich.cc:23: display_cropped_rect.Intersect(clip_rect); How about gfx::Rect display_cropped_rect = gfx::IntersectRects(*display_rect, clip_rect)
5 years, 2 months ago (2015-09-29 04:11:14 UTC) #3
Andre
https://codereview.chromium.org/1370363002/diff/20001/cc/output/overlay_strategy_sandwich.cc File cc/output/overlay_strategy_sandwich.cc (right): https://codereview.chromium.org/1370363002/diff/20001/cc/output/overlay_strategy_sandwich.cc#newcode13 cc/output/overlay_strategy_sandwich.cc:13: #include "ui/gfx/geometry/rect_conversions.h" Don't need this include anymore. Also dip_util.h.
5 years, 2 months ago (2015-09-29 04:18:05 UTC) #4
ccameron
Thanks! https://codereview.chromium.org/1370363002/diff/20001/cc/output/overlay_strategy_sandwich.cc File cc/output/overlay_strategy_sandwich.cc (right): https://codereview.chromium.org/1370363002/diff/20001/cc/output/overlay_strategy_sandwich.cc#newcode13 cc/output/overlay_strategy_sandwich.cc:13: #include "ui/gfx/geometry/rect_conversions.h" On 2015/09/29 04:18:05, Andre wrote: > ...
5 years, 2 months ago (2015-09-29 06:58:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370363002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370363002/60001
5 years, 2 months ago (2015-09-29 07:01:36 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/126780)
5 years, 2 months ago (2015-09-29 07:22:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370363002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370363002/60001
5 years, 2 months ago (2015-09-29 14:07:05 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-09-29 14:24:07 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 14:25:01 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e790d9f582a00168faf0aa81f6fe5477848bec2b
Cr-Commit-Position: refs/heads/master@{#351312}

Powered by Google App Engine
This is Rietveld 408576698