Mac Overlays: Clip display and UV rects

Mac Overlays: Clip display and UV rects

Make the Mac-specific sandwich strategy apply clipping to the display
rectangle. Apply the same relative clipping to the uv rectangle.

Add unit tests, and move code around to improve readability.

BUG=536854
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/e790d9f582a00168faf0aa81f6fe5477848bec2b
Cr-Commit-Position: refs/heads/master@{#351312}

[ccameron, 2015-09-29 00:24:31]

ccameron@chromium.org changed reviewers:
+ andresantoso@chromium.org

[ccameron, 2015-09-29 00:24:32]

https://codereview.chromium.org/1370363002/diff/20001/cc/output/overlay_strat...
File cc/output/overlay_strategy_common.cc (right):

https://codereview.chromium.org/1370363002/diff/20001/cc/output/overlay_strat...
cc/output/overlay_strategy_common.cc:199:
draw_quad.shared_quad_state->quad_to_target_transform, draw_quad.rect);
Put these two next to each other, to emphasize that they're the same value, just
rounded (or not) differently.

https://codereview.chromium.org/1370363002/diff/20001/cc/output/overlay_strat...
File cc/output/overlay_strategy_sandwich.cc (right):

https://codereview.chromium.org/1370363002/diff/20001/cc/output/overlay_strat...
cc/output/overlay_strategy_sandwich.cc:58: gfx::Rect candidate_pixel_rect =
candidate.quad_rect_in_target_space;
Here I exploit that those display_rect and quad_rect_in_target_space are
(basically) the same.

[Andre, 2015-09-29 04:11:14]

LGTM

https://codereview.chromium.org/1370363002/diff/20001/cc/output/overlay_strat...
File cc/output/overlay_strategy_sandwich.cc (right):

https://codereview.chromium.org/1370363002/diff/20001/cc/output/overlay_strat...
cc/output/overlay_strategy_sandwich.cc:23:
display_cropped_rect.Intersect(clip_rect);
How about
gfx::Rect display_cropped_rect = gfx::IntersectRects(*display_rect, clip_rect)

[Andre, 2015-09-29 04:18:05]

https://codereview.chromium.org/1370363002/diff/20001/cc/output/overlay_strat...
File cc/output/overlay_strategy_sandwich.cc (right):

https://codereview.chromium.org/1370363002/diff/20001/cc/output/overlay_strat...
cc/output/overlay_strategy_sandwich.cc:13: #include
"ui/gfx/geometry/rect_conversions.h"
Don't need this include anymore.
Also dip_util.h.

[ccameron, 2015-09-29 06:58:53]

Thanks!

https://codereview.chromium.org/1370363002/diff/20001/cc/output/overlay_strat...
File cc/output/overlay_strategy_sandwich.cc (right):

https://codereview.chromium.org/1370363002/diff/20001/cc/output/overlay_strat...
cc/output/overlay_strategy_sandwich.cc:13: #include
"ui/gfx/geometry/rect_conversions.h"
On 2015/09/29 04:18:05, Andre wrote:
> Don't need this include anymore.
> Also dip_util.h.

Done.

https://codereview.chromium.org/1370363002/diff/20001/cc/output/overlay_strat...
cc/output/overlay_strategy_sandwich.cc:23:
display_cropped_rect.Intersect(clip_rect);
On 2015/09/29 04:11:14, Andre wrote:
> How about
> gfx::Rect display_cropped_rect = gfx::IntersectRects(*display_rect, clip_rect)

Yes, that's better. Done.

[ccameron, 2015-09-29 07:01:30]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2015-09-29 07:01:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
andresantoso@chromium.org
Link to the patchset: https://codereview.chromium.org/1370363002/#ps60001
(title: "irf")

[commit-bot: I haz the power, 2015-09-29 07:01:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370363002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370363002/60001

[commit-bot: I haz the power, 2015-09-29 07:22:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-29 07:22:03]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[Andre, 2015-09-29 14:06:56]

The CQ bit was checked by andresantoso@chromium.org

[commit-bot: I haz the power, 2015-09-29 14:07:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370363002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370363002/60001

[commit-bot: I haz the power, 2015-09-29 14:24:07]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-29 14:25:01]

Patchset 4 (id:??) landed as
https://crrev.com/e790d9f582a00168faf0aa81f6fe5477848bec2b
Cr-Commit-Position: refs/heads/master@{#351312}