Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1384403002: Preparation for moving reusable handles to thread and more cleanups: isolate -> thread based handle… (Closed)

Created:
5 years, 2 months ago by srdjan
Modified:
5 years, 2 months ago
Reviewers:
koda
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Preparation for moving reusable handles to thread and more cleanups: isolate -> thread based handle allocation. BUG= R=koda@google.com Committed: https://github.com/dart-lang/sdk/commit/8c7a94e9f49618dfad5b2da4cd7738fe2d7094bf

Patch Set 1 #

Total comments: 3

Patch Set 2 : Added comment #

Patch Set 3 : Do not store thread in debugger, it is used by several threads (one isolate)" #

Patch Set 4 : Fixed import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -122 lines) Patch
M runtime/lib/mirrors.cc View 1 7 chunks +11 lines, -11 lines 0 comments Download
M runtime/vm/allocation.h View 3 chunks +4 lines, -30 lines 0 comments Download
M runtime/vm/allocation.cc View 2 chunks +36 lines, -0 lines 0 comments Download
M runtime/vm/class_finalizer.cc View 3 chunks +12 lines, -10 lines 0 comments Download
M runtime/vm/coverage.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/debugger.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/exceptions.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/gc_marker.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/intrinsifier.cc View 1 2 chunks +8 lines, -7 lines 0 comments Download
M runtime/vm/mirrors_api_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/native_entry.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/native_entry_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/object.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/object.cc View 1 18 chunks +51 lines, -38 lines 0 comments Download
M runtime/vm/precompiler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/snapshot.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/stack_frame.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stack_frame.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/stub_code.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/zone.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
srdjan
5 years, 2 months ago (2015-10-05 23:47:04 UTC) #2
koda
lgtm https://codereview.chromium.org/1384403002/diff/1/runtime/vm/gc_marker.h File runtime/vm/gc_marker.h (right): https://codereview.chromium.org/1384403002/diff/1/runtime/vm/gc_marker.h#newcode9 runtime/vm/gc_marker.h:9: #include "vm/thread.h" Unused?
5 years, 2 months ago (2015-10-06 00:02:59 UTC) #3
srdjan
https://codereview.chromium.org/1384403002/diff/1/runtime/vm/gc_marker.h File runtime/vm/gc_marker.h (right): https://codereview.chromium.org/1384403002/diff/1/runtime/vm/gc_marker.h#newcode9 runtime/vm/gc_marker.h:9: #include "vm/thread.h" On 2015/10/06 00:02:58, koda wrote: > Unused? ...
5 years, 2 months ago (2015-10-06 16:25:30 UTC) #4
koda
On 2015/10/06 16:25:30, srdjan wrote: > https://codereview.chromium.org/1384403002/diff/1/runtime/vm/gc_marker.h > File runtime/vm/gc_marker.h (right): > > https://codereview.chromium.org/1384403002/diff/1/runtime/vm/gc_marker.h#newcode9 > ...
5 years, 2 months ago (2015-10-06 16:37:43 UTC) #5
srdjan
On 2015/10/06 16:37:43, koda wrote: > On 2015/10/06 16:25:30, srdjan wrote: > > https://codereview.chromium.org/1384403002/diff/1/runtime/vm/gc_marker.h > ...
5 years, 2 months ago (2015-10-06 17:00:31 UTC) #6
srdjan
https://codereview.chromium.org/1384403002/diff/1/runtime/vm/gc_marker.h File runtime/vm/gc_marker.h (right): https://codereview.chromium.org/1384403002/diff/1/runtime/vm/gc_marker.h#newcode9 runtime/vm/gc_marker.h:9: #include "vm/thread.h" On 2015/10/06 16:25:30, srdjan wrote: > On ...
5 years, 2 months ago (2015-10-06 17:02:30 UTC) #7
srdjan
5 years, 2 months ago (2015-10-06 17:17:28 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
8c7a94e9f49618dfad5b2da4cd7738fe2d7094bf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698