runtime/vm/native_entry.h - Issue 1384403002: Preparation for moving reusable handles to thread and more cleanups: isolate -> thread based handle…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/native_entry.h

Issue 1384403002: Preparation for moving reusable handles to thread and more cleanups: isolate -> thread based handle… (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Fixed import Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/native_entry.h

diff --git a/runtime/vm/native_entry.h b/runtime/vm/native_entry.h

index 0123b47383ca9869c4bf7cb75243627f50d56345..25dee390c9ee7a8ff8f13a5ce7936f4735464e06 100644

--- a/runtime/vm/native_entry.h

+++ b/runtime/vm/native_entry.h

@@ -88,7 +88,7 @@ typedef void (*NativeFunction)(NativeArguments* arguments);

#define GET_NATIVE_ARGUMENT(type, name, value) \

const Instance& __##name##_instance__ = \

Instance::CheckedHandle(zone, value); \

- type& name = type::Handle(isolate); \

+ type& name = type::Handle(zone); \

if (!__##name##_instance__.IsNull()) { \

if (!__##name##_instance__.Is##type()) { \

const Array& __args__ = Array::Handle(Array::New(1)); \

« no previous file with comments | « runtime/vm/mirrors_api_impl.cc ('k') | runtime/vm/native_entry_test.cc » ('j') | no next file with comments »