runtime/vm/mirrors_api_impl.cc - Issue 1384403002: Preparation for moving reusable handles to thread and more cleanups: isolate -> thread based handle…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/mirrors_api_impl.cc

Issue 1384403002: Preparation for moving reusable handles to thread and more cleanups: isolate -> thread based handle… (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Fixed import Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/mirrors_api_impl.cc

diff --git a/runtime/vm/mirrors_api_impl.cc b/runtime/vm/mirrors_api_impl.cc

index 3d83d44aead4fac069a3eb0044c8dfb3c4998271..cb3b93fb639474da78877a91c5abdb654b86b3cb 100644

--- a/runtime/vm/mirrors_api_impl.cc

+++ b/runtime/vm/mirrors_api_impl.cc

@@ -83,7 +83,7 @@ DART_EXPORT Dart_Handle Dart_GetFunctionNames(Dart_Handle target) {

if (obj.IsType()) {

const Class& cls = Class::Handle(Z, Type::Cast(obj).type_class());

- const Error& error = Error::Handle(Z, cls.EnsureIsFinalized(I));

+ const Error& error = Error::Handle(Z, cls.EnsureIsFinalized(T));

if (!error.IsNull()) {

return Api::NewHandle(I, error.raw());

}

« no previous file with comments | « runtime/vm/intrinsifier.cc ('k') | runtime/vm/native_entry.h » ('j') | no next file with comments »