Reland of [Background Sync] Trigger Background Sync events when Chrome is backgrounded on Android

Reland of [Background Sync] Trigger Background Sync events when Chrome is backgrounded on Android

Original review: https://codereview.chromium.org/1294603003/
  (Committed as https://crrev.com/a5fb97d6fb9c3831994aadebea4664e2acc3c356)
Reverted in https://codereview.chromium.org/1376563003/
  (as https://crrev.com/c532c674b657426cb733c2b735bbf5741bcbea48)

BUG=511129
Committed: https://crrev.com/9c6db4187afa85c03bd7a0e697cc7ff1986e4b77
Cr-Commit-Position: refs/heads/master@{#352019}

[iclelland, 2015-10-01 15:01:03]

iclelland@chromium.org changed reviewers:
+ jkarlin@chromium.org

[iclelland, 2015-10-01 15:01:26]

jkarlin -- PTAL at the changes for the reland, thanks!

[jkarlin, 2015-10-01 15:10:07]

lgtm

[iclelland, 2015-10-01 15:14:47]

iclelland@chromium.org changed reviewers:
+ jochen@chromium.org, mmenke@chromium.org, yfriedman@google.com

[iclelland, 2015-10-01 15:18:02]

+r yfriedman, jochen, mmenke

yfriedman: Can you check the Android code for sanity? Also, approval for
DEPS-dependent-change for browser JNI 
jochen: Need owner approval for components/*
mmenke: Need owner approval for DEPS-dependent change for net JNI

Thanks, all, and sorry for the duplicated work.

[mmenke, 2015-10-01 15:21:26]

On 2015/10/01 15:18:02, iclelland wrote:
> +r yfriedman, jochen, mmenke
> 
> yfriedman: Can you check the Android code for sanity? Also, approval for
> DEPS-dependent-change for browser JNI 
> jochen: Need owner approval for components/*
> mmenke: Need owner approval for DEPS-dependent change for net JNI
> 
> Thanks, all, and sorry for the duplicated work.

Still LGTM - note that for relands, you can generally just TBR people who
previously signed off, at least if what they signed off on is unrelated to the
problem you fixed.  Can't do that if you're not yet a full committer, though.

[Yaron, 2015-10-01 15:37:37]

yfriedman@chromium.org changed reviewers:
+ yfriedman@chromium.org

[Yaron, 2015-10-01 15:37:37]

yfriedman@chromium.org changed reviewers:
+ yfriedman@chromium.org

[Yaron, 2015-10-01 15:37:37]

https://codereview.chromium.org/1383663004/diff/20001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/BackgroundSyncNetworkObserver.java
(right):

https://codereview.chromium.org/1383663004/diff/20001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/BackgroundSyncNetworkObserver.java:53:
return ctx.checkPermission(
Is your intention to refactor this later so webview never hits this?

[iclelland, 2015-10-01 15:43:48]

On 2015/10/01 15:37:37, Yaron wrote:
>
https://codereview.chromium.org/1383663004/diff/20001/content/public/android/...
> File
>
content/public/android/java/src/org/chromium/content/browser/BackgroundSyncNetworkObserver.java
> (right):
> 
>
https://codereview.chromium.org/1383663004/diff/20001/content/public/android/...
>
content/public/android/java/src/org/chromium/content/browser/BackgroundSyncNetworkObserver.java:53:
> return ctx.checkPermission(
> Is your intention to refactor this later so webview never hits this?

Yes, the eventual intention (see crbug.com/522596) is move all of this into a
location where WebView won't actually access any of this code at all. Likely
through componentization, although the design isn't fixed yet.

[Yaron, 2015-10-01 15:50:57]

lgtm

[jochen (gone - plz use gerrit), 2015-10-02 13:20:46]

lgtm

[iclelland, 2015-10-02 13:24:39]

The CQ bit was checked by iclelland@chromium.org

[commit-bot: I haz the power, 2015-10-02 13:25:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1383663004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1383663004/20001

[commit-bot: I haz the power, 2015-10-02 13:35:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-02 13:36:02]

Patchset 2 (id:??) landed as
https://crrev.com/9c6db4187afa85c03bd7a0e697cc7ff1986e4b77
Cr-Commit-Position: refs/heads/master@{#352019}