content/browser/background_sync/background_sync_manager.h - Issue 1383663004: Reland of [Background Sync] Trigger Background Sync events when Chrome is backgrounded on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/background_sync/background_sync_manager.h

Issue 1383663004: Reland of [Background Sync] Trigger Background Sync events when Chrome is backgrounded on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Don't crash in embedded webview; check permissions before creating NCNAD Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/background_sync/background_sync_browsertest.cc ('k') | content/browser/background_sync/background_sync_manager.cc » ('j') | content/public/android/java/src/org/chromium/content/browser/BackgroundSyncNetworkObserver.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/background_sync/background_sync_manager.h

diff --git a/content/browser/background_sync/background_sync_manager.h b/content/browser/background_sync/background_sync_manager.h

index 999b310878842ae2356b50a8a25f6fea6c29ff2a..a845dd3a249d3ee18a84ea61b79b932c7b8ebd9d 100644

--- a/content/browser/background_sync/background_sync_manager.h

+++ b/content/browser/background_sync/background_sync_manager.h

@@ -99,6 +99,10 @@ class CONTENT_EXPORT BackgroundSyncManager

const GURL& pattern) override;

void OnStorageWiped() override;

+ BackgroundSyncNetworkObserver* GetNetworkObserverForTesting() {

+ return network_observer_.get();

+ }

protected:

// A registration might be referenced by the client longer than

// the BackgroundSyncManager needs to keep track of it (e.g., the event has