content/browser/background_sync/background_sync_manager.cc - Issue 1383663004: Reland of [Background Sync] Trigger Background Sync events when Chrome is backgrounded on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/background_sync/background_sync_manager.cc

Issue 1383663004: Reland of [Background Sync] Trigger Background Sync events when Chrome is backgrounded on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Don't crash in embedded webview; check permissions before creating NCNAD Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/background_sync/background_sync_manager.h ('k') | content/browser/background_sync/background_sync_manager_unittest.cc » ('j') | content/public/android/java/src/org/chromium/content/browser/BackgroundSyncNetworkObserver.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/background_sync/background_sync_manager.cc

diff --git a/content/browser/background_sync/background_sync_manager.cc b/content/browser/background_sync/background_sync_manager.cc

index 07ac7d826da13d27755dc09ab46022da5a1232f3..477b31f02d7edf62866357fabacea23406c72b80 100644

--- a/content/browser/background_sync/background_sync_manager.cc

+++ b/content/browser/background_sync/background_sync_manager.cc

@@ -21,6 +21,7 @@

#if defined(OS_ANDROID)

#include "content/browser/android/background_sync_launcher_android.h"

+#include "content/browser/android/background_sync_network_observer_android.h"

#endif

namespace content {

@@ -221,9 +222,15 @@ BackgroundSyncManager::BackgroundSyncManager(

service_worker_context_->AddObserver(this);

+#if defined(OS_ANDROID)

+ network_observer_.reset(new BackgroundSyncNetworkObserverAndroid(

+ base::Bind(&BackgroundSyncManager::OnNetworkChanged,

+ weak_ptr_factory_.GetWeakPtr())));

+#else

network_observer_.reset(new BackgroundSyncNetworkObserver(

base::Bind(&BackgroundSyncManager::OnNetworkChanged,

weak_ptr_factory_.GetWeakPtr())));

+#endif

power_observer_.reset(new BackgroundSyncPowerObserver(base::Bind(

&BackgroundSyncManager::OnPowerChanged, weak_ptr_factory_.GetWeakPtr())));

}