Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: net/http/http_auth_handler_factory.cc

Issue 1383613002: [net/http auth] Cleanup. Method names, and constness. Base URL: https://chromium.googlesource.com/chromium/src.git@mock-auth-handler-generalization
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth_handler_factory.h ('k') | net/http/http_auth_handler_factory_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_handler_factory.cc
diff --git a/net/http/http_auth_handler_factory.cc b/net/http/http_auth_handler_factory.cc
index 5f24fccf3724c8533cf4d3b930dbed4c65c5b169..90b29c7e76cef3cf0bc2d93a4d09629ebd4970fa 100644
--- a/net/http/http_auth_handler_factory.cc
+++ b/net/http/http_auth_handler_factory.cc
@@ -26,8 +26,8 @@ int HttpAuthHandlerFactory::CreateAuthHandlerFromString(
const BoundNetLog& net_log,
scoped_ptr<HttpAuthHandler>* handler) {
HttpAuthChallengeTokenizer props(challenge.begin(), challenge.end());
- return CreateAuthHandler(&props, target, origin, CREATE_CHALLENGE, 1,
- net_log, handler);
+ return CreateAuthHandler(props, target, origin, CREATE_CHALLENGE, 1, net_log,
+ handler);
}
int HttpAuthHandlerFactory::CreatePreemptiveAuthHandlerFromString(
@@ -38,7 +38,7 @@ int HttpAuthHandlerFactory::CreatePreemptiveAuthHandlerFromString(
const BoundNetLog& net_log,
scoped_ptr<HttpAuthHandler>* handler) {
HttpAuthChallengeTokenizer props(challenge.begin(), challenge.end());
- return CreateAuthHandler(&props, target, origin, CREATE_PREEMPTIVE,
+ return CreateAuthHandler(props, target, origin, CREATE_PREEMPTIVE,
digest_nonce_count, net_log, handler);
}
@@ -178,14 +178,14 @@ HttpAuthHandlerRegistryFactory* HttpAuthHandlerRegistryFactory::Create(
}
int HttpAuthHandlerRegistryFactory::CreateAuthHandler(
- HttpAuthChallengeTokenizer* challenge,
+ const HttpAuthChallengeTokenizer& challenge,
HttpAuth::Target target,
const GURL& origin,
CreateReason reason,
int digest_nonce_count,
const BoundNetLog& net_log,
scoped_ptr<HttpAuthHandler>* handler) {
- std::string scheme = challenge->NormalizedScheme();
+ std::string scheme = challenge.NormalizedScheme();
if (scheme.empty()) {
handler->reset();
return ERR_INVALID_RESPONSE;
« no previous file with comments | « net/http/http_auth_handler_factory.h ('k') | net/http/http_auth_handler_factory_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698