Reland: Store |detail| as a hidden value of custom event wrappers

Reland: Store |detail| as a hidden value of custom event wrappers

The original CL was reverted because it broke google image search.
This CL stores |detail| as a hidden value when initCustomEvent() is called
instead of serializing it.

Original description:

We cannot hold strong references from Blink to V8. This means
that we shouldn't use ScriptValue in DOM impl objects.
To stop using ScriptValue in CustomEvent, store |detail|
as a hidden value of custom event wrappers and return it when
the getter of |detail| is called.

BUG=529941
Committed: https://crrev.com/ce8a2dfe58ba9c8a9fe999124a5a7eaabf1e0851
Cr-Commit-Position: refs/heads/master@{#352490}

[bashi, 2015-10-01 23:37:22]

bashi@chromium.org changed reviewers:
+ haraken@chromium.org

[bashi, 2015-10-01 23:37:23]

PTAL?

PS#1 is the original CL
PS#2 contains the fix of bug 537567

[haraken, 2015-10-01 23:43:13]

LGTM, thanks for the quick fix!

https://codereview.chromium.org/1383543004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp
(right):

https://codereview.chromium.org/1383543004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp:103:
v8::Local<v8::Value> detail = info[3];

Shall we add ASSERT(info.Length() >= 3) ?

[bashi, 2015-10-01 23:52:36]

Thanks!

https://codereview.chromium.org/1383543004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp
(right):

https://codereview.chromium.org/1383543004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp:103:
v8::Local<v8::Value> detail = info[3];
On 2015/10/01 23:43:12, haraken wrote:
> 
> Shall we add ASSERT(info.Length() >= 3) ?

Done.

[bashi, 2015-10-01 23:52:41]

The CQ bit was checked by bashi@chromium.org

[bashi, 2015-10-01 23:52:41]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1383543004/#ps40001
(title: "assert")

[commit-bot: I haz the power, 2015-10-01 23:53:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1383543004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1383543004/40001

[commit-bot: I haz the power, 2015-10-02 00:03:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-02 00:03:10]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[bashi, 2015-10-06 00:31:34]

The CQ bit was checked by bashi@chromium.org

[bashi, 2015-10-06 00:31:34]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1383543004/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-10-06 00:32:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1383543004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1383543004/60001

[commit-bot: I haz the power, 2015-10-06 00:42:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-10-06 00:44:07]

Patchset 4 (id:??) landed as
https://crrev.com/ce8a2dfe58ba9c8a9fe999124a5a7eaabf1e0851
Cr-Commit-Position: refs/heads/master@{#352490}