Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: third_party/WebKit/Source/core/events/CustomEvent.cpp

Issue 1383543004: Reland: Store |detail| as a hidden value of custom event wrappers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/events/CustomEvent.cpp
diff --git a/third_party/WebKit/Source/core/events/CustomEvent.cpp b/third_party/WebKit/Source/core/events/CustomEvent.cpp
index a9c87cbbdf8ef778d4d06ccfcbf882eef18a330c..9d9c6eaf889a52c48c8b72a399e2edb70464ab40 100644
--- a/third_party/WebKit/Source/core/events/CustomEvent.cpp
+++ b/third_party/WebKit/Source/core/events/CustomEvent.cpp
@@ -27,6 +27,7 @@
#include "core/events/CustomEvent.h"
#include "bindings/core/v8/SerializedScriptValue.h"
+#include "bindings/core/v8/SerializedScriptValueFactory.h"
namespace blink {
@@ -37,18 +38,15 @@ CustomEvent::CustomEvent()
CustomEvent::CustomEvent(const AtomicString& type, const CustomEventInit& initializer)
: Event(type, initializer)
{
- if (initializer.hasDetail())
- m_detail = initializer.detail();
}
CustomEvent::~CustomEvent()
{
}
-void CustomEvent::initCustomEvent(const AtomicString& type, bool canBubble, bool cancelable, const ScriptValue& detail)
+void CustomEvent::initCustomEvent(const AtomicString& type, bool canBubble, bool cancelable, const ScriptValue&)
{
initEvent(type, canBubble, cancelable);
- m_detail = detail;
}
void CustomEvent::initCustomEvent(const AtomicString& type, bool canBubble, bool cancelable, PassRefPtr<SerializedScriptValue> serializedDetail)
« no previous file with comments | « third_party/WebKit/Source/core/events/CustomEvent.h ('k') | third_party/WebKit/Source/core/events/CustomEvent.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698