third_party/WebKit/Source/core/events/CustomEvent.h - Issue 1383543004: Reland: Store |detail| as a hidden value of custom event wrappers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/events/CustomEvent.h

Issue 1383543004: Reland: Store |detail| as a hidden value of custom event wrappers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp ('k') | third_party/WebKit/Source/core/events/CustomEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/events/CustomEvent.h

diff --git a/third_party/WebKit/Source/core/events/CustomEvent.h b/third_party/WebKit/Source/core/events/CustomEvent.h

index 82d5f357081a276ef90f0fac1c6cb51382693d19..9ae76f8477bbfce0110b30bc9487eb8ec39c322a 100644

--- a/third_party/WebKit/Source/core/events/CustomEvent.h

+++ b/third_party/WebKit/Source/core/events/CustomEvent.h

@@ -55,8 +55,7 @@ public:

const AtomicString& interfaceName() const override;

SerializedScriptValue* serializedDetail() { return m_serializedDetail.get(); }

- ScriptValue detail() const { return m_detail; }

+ void setSerializedDetail(PassRefPtr<SerializedScriptValue> serializedDetail) { m_serializedDetail = serializedDetail; }

DECLARE_VIRTUAL_TRACE();

@@ -64,7 +63,6 @@ private:

CustomEvent();

CustomEvent(const AtomicString& type, const CustomEventInit& initializer);

- ScriptValue m_detail;

RefPtr<SerializedScriptValue> m_serializedDetail;

};