[Cronet] Expose HttpURLConnection API from CronetEngine, not classes

[Cronet] Expose HttpURLConnection API from CronetEngine, not classes

There's no reason to expose these APIs via full-fledged classes and it
complicates the Cronet API, so simpy expose three functions on
CronetEngine that use the java.net APIs.

Also fix a couple tiny javadoc problems:
 1) add some missing packages from package-list
 2) @hide doesn't work (need doclava) so use @deprecated for now

BUG=531538
Committed: https://crrev.com/f09f7804c482794be913d2e7147b8f3c53ba1079
Cr-Commit-Position: refs/heads/master@{#353056}

[pauljensen, 2015-10-02 15:24:10]

pauljensen@chromium.org changed reviewers:
+ xunjieli@chromium.org

[pauljensen, 2015-10-02 15:24:11]

Helen, PTAL.

[xunjieli, 2015-10-02 15:49:06]

It'll be useful to see if this change increases dex method counts for the sample
app. The tool I used is https://github.com/mihaip/dex-method-count. I don't
think it would, but it might a double check.

https://codereview.chromium.org/1383023003/diff/1/components/cronet/android/j...
File components/cronet/android/java/src/org/chromium/net/CronetEngine.java
(right):

https://codereview.chromium.org/1383023003/diff/1/components/cronet/android/j...
components/cronet/android/java/src/org/chromium/net/CronetEngine.java:175: *    
    javadocs are built with nodeprecated="yes".
This is a little hacky to use @deprecated to hide the javadoc. I wonder whether
we can make use of Doclava (https://code.google.com/p/doclava/), which is used
to generate the android references. It works with ant as well. It has an
internal site.

I don't think it'll be straight-forward. Maybe we can make it work?

https://codereview.chromium.org/1383023003/diff/1/components/cronet/android/j...
components/cronet/android/java/src/org/chromium/net/CronetEngine.java:471:
public abstract URLConnection openConnection(URL url, Proxy proxy);
Maybe add in the javadoc that this method is not implemented, and optionally a
link to the crbug.com/418111

[pauljensen, 2015-10-02 23:39:43]

Appears to increase dex-count by 7, 6 of which are in org.chromium.net.  I dunno
if that's a big deal.

https://codereview.chromium.org/1383023003/diff/1/components/cronet/android/j...
File components/cronet/android/java/src/org/chromium/net/CronetEngine.java
(right):

https://codereview.chromium.org/1383023003/diff/1/components/cronet/android/j...
components/cronet/android/java/src/org/chromium/net/CronetEngine.java:175: *    
    javadocs are built with nodeprecated="yes".
On 2015/10/02 15:49:06, xunjieli wrote:
> This is a little hacky to use @deprecated to hide the javadoc. I wonder
whether
> we can make use of Doclava (https://code.google.com/p/doclava/), which is used
> to generate the android references. It works with ant as well. It has an
> internal site.
> 
> I don't think it'll be straight-forward. Maybe we can make it work?

I looked into doclava before uploading this CL (see note in commit description).
 I don't think it'll be trivial to add (it's not small and I couldn't seem to
find a pre-existing copy in the Chromium repository) so I'd say do this in
another CL.  Perhaps after we finish the API work.

https://codereview.chromium.org/1383023003/diff/1/components/cronet/android/j...
components/cronet/android/java/src/org/chromium/net/CronetEngine.java:471:
public abstract URLConnection openConnection(URL url, Proxy proxy);
On 2015/10/02 15:49:06, xunjieli wrote:
> Maybe add in the javadoc that this method is not implemented, and optionally a
> link to the crbug.com/418111

I hid it like I did setDataReductionProxyOptions() as there's no point in
exposing an API that isn't implemented.  I also added a note to expose once
implemented with bug link.

[xunjieli, 2015-10-05 15:43:49]

LGTM. 7, 6 shouldn't be a big deal. 
Btw, could you also file a bug to do @hide? so we don't lose track of it :)

[pauljensen, 2015-10-05 18:58:06]

On 2015/10/05 15:43:49, xunjieli wrote:
> LGTM. 7, 6 shouldn't be a big deal. 
> Btw, could you also file a bug to do @hide? so we don't lose track of it :)

http://crbug.com/539519

[pauljensen, 2015-10-08 00:27:20]

Oops, just realized I forgot to update the readme.  Done.  PTAL.

[xunjieli, 2015-10-08 14:17:57]

Good catch! LGTM with nits.

https://codereview.chromium.org/1383023003/diff/80001/components/cronet/READM...
File components/cronet/README.md (right):

https://codereview.chromium.org/1383023003/diff/80001/components/cronet/READM...
components/cronet/README.md:155:
URL.setURLStreamHandlerFactory(engine.createURLStreamHandlerFactory();
nit: missing closing parenthesis.

https://codereview.chromium.org/1383023003/diff/80001/components/cronet/andro...
File components/cronet/android/java/src/org/chromium/net/CronetEngine.java
(right):

https://codereview.chromium.org/1383023003/diff/80001/components/cronet/andro...
components/cronet/android/java/src/org/chromium/net/CronetEngine.java:556: *
{@link java.net.URL#setURLStreamHandlerFactory} thus using this CronetEngine by
default for
optional nit: Can use shorthand {@link URL#setURLStreamHandlerFactory} here and
on the next line.

https://codereview.chromium.org/1383023003/diff/80001/components/cronet/andro...
components/cronet/android/java/src/org/chromium/net/CronetEngine.java:582: *
@return an {@link java.net.URLStreamHandlerFactory} instance implemented by this
optional nit: Since URLStreamHandlerFactory is imported, can use shorthand here
"{@link URLStreamHandlerFactory}". On line 554, the shorthand is used.

[pauljensen, 2015-10-08 14:40:34]

https://codereview.chromium.org/1383023003/diff/80001/components/cronet/READM...
File components/cronet/README.md (right):

https://codereview.chromium.org/1383023003/diff/80001/components/cronet/READM...
components/cronet/README.md:155:
URL.setURLStreamHandlerFactory(engine.createURLStreamHandlerFactory();
On 2015/10/08 14:17:56, xunjieli wrote:
> nit: missing closing parenthesis.

Done.

https://codereview.chromium.org/1383023003/diff/80001/components/cronet/andro...
File components/cronet/android/java/src/org/chromium/net/CronetEngine.java
(right):

https://codereview.chromium.org/1383023003/diff/80001/components/cronet/andro...
components/cronet/android/java/src/org/chromium/net/CronetEngine.java:556: *
{@link java.net.URL#setURLStreamHandlerFactory} thus using this CronetEngine by
default for
On 2015/10/08 14:17:56, xunjieli wrote:
> optional nit: Can use shorthand {@link URL#setURLStreamHandlerFactory} here
and
> on the next line.

Done.

https://codereview.chromium.org/1383023003/diff/80001/components/cronet/andro...
components/cronet/android/java/src/org/chromium/net/CronetEngine.java:582: *
@return an {@link java.net.URLStreamHandlerFactory} instance implemented by this
On 2015/10/08 14:17:56, xunjieli wrote:
> optional nit: Since URLStreamHandlerFactory is imported, can use shorthand
here
> "{@link URLStreamHandlerFactory}". On line 554, the shorthand is used.

Done.

[pauljensen, 2015-10-08 14:41:38]

The CQ bit was checked by pauljensen@chromium.org

[pauljensen, 2015-10-08 14:41:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
xunjieli@chromium.org
Link to the patchset: https://codereview.chromium.org/1383023003/#ps100001
(title: "address nits")

[commit-bot: I haz the power, 2015-10-08 15:02:33]

Patchset 6 (id:??) landed as
https://crrev.com/f09f7804c482794be913d2e7147b8f3c53ba1079
Cr-Commit-Position: refs/heads/master@{#353056}