Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLStreamHandler.java

Issue 1383023003: [Cronet] Expose HttpURLConnection API from CronetEngine, not classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@builder2
Patch Set: address nits Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLStreamHandler.java
diff --git a/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLStreamHandler.java b/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLStreamHandler.java
index c962e74d0da591954079ffad2474fa9837763cea..8cf5ea7353c83f05708106dd551ab4dd9d7e0f6f 100644
--- a/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLStreamHandler.java
+++ b/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLStreamHandler.java
@@ -22,7 +22,7 @@ import java.net.URLStreamHandler;
* <b>Note:</b> Cronet's {@code HttpURLConnection} implementation is subject to some limitations
* listed {@link CronetURLStreamHandlerFactory here}.
*/
-public class CronetHttpURLStreamHandler extends URLStreamHandler {
+class CronetHttpURLStreamHandler extends URLStreamHandler {
private final CronetEngine mCronetEngine;
public CronetHttpURLStreamHandler(CronetEngine cronetEngine) {
@@ -35,12 +35,7 @@ public class CronetHttpURLStreamHandler extends URLStreamHandler {
*/
@Override
public URLConnection openConnection(URL url) throws IOException {
- String protocol = url.getProtocol();
- if ("http".equals(protocol) || "https".equals(protocol)) {
- return new CronetHttpURLConnection(url, mCronetEngine);
- }
- throw new UnsupportedOperationException(
- "Unexpected protocol:" + protocol);
+ return mCronetEngine.openConnection(url);
}
/**
@@ -50,6 +45,6 @@ public class CronetHttpURLStreamHandler extends URLStreamHandler {
*/
@Override
public URLConnection openConnection(URL url, Proxy proxy) {
- throw new UnsupportedOperationException();
+ return mCronetEngine.openConnection(url, proxy);
}
}

Powered by Google App Engine
This is Rietveld 408576698