Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java

Issue 1383023003: [Cronet] Expose HttpURLConnection API from CronetEngine, not classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@builder2
Patch Set: address nits Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/urlconnection/CronetURLStreamHandlerFactory.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java
diff --git a/components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java b/components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java
index 6d53f528f4bc14875de6917520fa87cbfeee43cf..c7ad7364e7659f6f62d611e83e6e4dfab805f219 100644
--- a/components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java
+++ b/components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java
@@ -11,7 +11,6 @@ import android.os.AsyncTask;
import android.os.Bundle;
import android.os.Debug;
-import org.chromium.net.urlconnection.CronetHttpURLStreamHandler;
import org.json.JSONException;
import org.json.JSONObject;
@@ -292,17 +291,11 @@ public class CronetPerfTestActivity extends Activity {
// GET or POST to one particular URL using Cronet HttpURLConnection API
private class CronetHttpURLConnectionFetchTask implements Callable<Boolean> {
private final byte[] mBuffer = new byte[mBufferSize];
- private final CronetHttpURLStreamHandler mStreamHandler;
-
- public CronetHttpURLConnectionFetchTask(
- CronetHttpURLStreamHandler cronetStreamHandler) {
- mStreamHandler = cronetStreamHandler;
- }
@Override
public Boolean call() {
try {
- return exerciseHttpURLConnection(mStreamHandler.openConnection(mUrl), mBuffer);
+ return exerciseHttpURLConnection(mCronetEngine.openConnection(mUrl), mBuffer);
} catch (IOException e) {
System.out.println("Cronet HttpURLConnection failed with " + e);
return false;
@@ -480,10 +473,8 @@ public class CronetPerfTestActivity extends Activity {
}
break;
case CRONET_HUC: {
- final CronetHttpURLStreamHandler cronetStreamHandler =
- new CronetHttpURLStreamHandler(mCronetEngine);
for (int i = 0; i < mIterations; i++) {
- tasks.add(new CronetHttpURLConnectionFetchTask(cronetStreamHandler));
+ tasks.add(new CronetHttpURLConnectionFetchTask());
}
break;
}
« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/urlconnection/CronetURLStreamHandlerFactory.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698