Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1383013002: SVGFilterBuilder::getEffectById never return nullptr (Closed)

Created:
5 years, 2 months ago by fs
Modified:
5 years, 2 months ago
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SVGFilterBuilder::getEffectById never return nullptr Drop the dead null-check-and-return to avoid giving the impression that it's actually a possible error path. BUG=533457 Committed: https://crrev.com/9c1e3f170a458ab3a5c83c701b8929d2f58a27ec Cr-Commit-Position: refs/heads/master@{#353282}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -37 lines) Patch
M third_party/WebKit/Source/core/svg/SVGFEBlendElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEColorMatrixElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEComponentTransferElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFECompositeElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEConvolveMatrixElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEDisplacementMapElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEDropShadowElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEGaussianBlurElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEMergeElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEOffsetElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFESpecularLightingElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFETileElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
fs
5 years, 2 months ago (2015-10-09 09:07:34 UTC) #2
f(malita)
lgtm
5 years, 2 months ago (2015-10-09 12:48:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1383013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1383013002/1
5 years, 2 months ago (2015-10-09 12:49:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-09 14:01:33 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9c1e3f170a458ab3a5c83c701b8929d2f58a27ec Cr-Commit-Position: refs/heads/master@{#353282}
5 years, 2 months ago (2015-10-09 14:03:00 UTC) #8
Stephen White
5 years, 2 months ago (2015-10-09 14:04:00 UTC) #9
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698