Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGFEBlendElement.cpp

Issue 1383013002: SVGFilterBuilder::getEffectById never return nullptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/SVGFEColorMatrixElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 return; 133 return;
134 } 134 }
135 135
136 SVGFilterPrimitiveStandardAttributes::svgAttributeChanged(attrName); 136 SVGFilterPrimitiveStandardAttributes::svgAttributeChanged(attrName);
137 } 137 }
138 138
139 PassRefPtrWillBeRawPtr<FilterEffect> SVGFEBlendElement::build(SVGFilterBuilder* filterBuilder, Filter* filter) 139 PassRefPtrWillBeRawPtr<FilterEffect> SVGFEBlendElement::build(SVGFilterBuilder* filterBuilder, Filter* filter)
140 { 140 {
141 FilterEffect* input1 = filterBuilder->getEffectById(AtomicString(m_in1->curr entValue()->value())); 141 FilterEffect* input1 = filterBuilder->getEffectById(AtomicString(m_in1->curr entValue()->value()));
142 FilterEffect* input2 = filterBuilder->getEffectById(AtomicString(m_in2->curr entValue()->value())); 142 FilterEffect* input2 = filterBuilder->getEffectById(AtomicString(m_in2->curr entValue()->value()));
143 143 ASSERT(input1 && input2);
144 if (!input1 || !input2)
145 return nullptr;
146 144
147 RefPtrWillBeRawPtr<FilterEffect> effect = FEBlend::create(filter, toWebBlend Mode(m_mode->currentValue()->enumValue())); 145 RefPtrWillBeRawPtr<FilterEffect> effect = FEBlend::create(filter, toWebBlend Mode(m_mode->currentValue()->enumValue()));
148 FilterEffectVector& inputEffects = effect->inputEffects(); 146 FilterEffectVector& inputEffects = effect->inputEffects();
149 inputEffects.reserveCapacity(2); 147 inputEffects.reserveCapacity(2);
150 inputEffects.append(input1); 148 inputEffects.append(input1);
151 inputEffects.append(input2); 149 inputEffects.append(input2);
152 return effect.release(); 150 return effect.release();
153 } 151 }
154 152
155 } 153 }
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/SVGFEColorMatrixElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698