third_party/WebKit/Source/core/svg/SVGFEOffsetElement.cpp - Issue 1383013002: SVGFilterBuilder::getEffectById never return nullptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGFEOffsetElement.cpp

Issue 1383013002: SVGFilterBuilder::getEffectById never return nullptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGFEMergeElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGFESpecularLightingElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGFEOffsetElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGFEOffsetElement.cpp b/third_party/WebKit/Source/core/svg/SVGFEOffsetElement.cpp

index 5bb9c2b47a7a1b015eee58aaa1b097967d6ad44d..14c0919504e26050014f3a61b2887ebebceebb97 100644

--- a/third_party/WebKit/Source/core/svg/SVGFEOffsetElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGFEOffsetElement.cpp

@@ -64,9 +64,7 @@ void SVGFEOffsetElement::svgAttributeChanged(const QualifiedName& attrName)

PassRefPtrWillBeRawPtr<FilterEffect> SVGFEOffsetElement::build(SVGFilterBuilder* filterBuilder, Filter* filter)

{

FilterEffect* input1 = filterBuilder->getEffectById(AtomicString(m_in1->currentValue()->value()));

- if (!input1)

- return nullptr;

+ ASSERT(input1);

RefPtrWillBeRawPtr<FilterEffect> effect = FEOffset::create(filter, m_dx->currentValue()->value(), m_dy->currentValue()->value());

effect->inputEffects().append(input1);