Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 1382403002: Clean up hints (Closed)

Created:
5 years, 2 months ago by Brian Wilkerson
Modified:
5 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -64 lines) Patch
M pkg/analysis_server/lib/src/services/completion/completion_manager.dart View 1 chunk +3 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +0 lines, -40 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/analyzer/test/source/analysis_options_provider_test.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/task/strong_mode_test.dart View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
5 years, 2 months ago (2015-10-05 14:56:22 UTC) #2
scheglov
LGTM
5 years, 2 months ago (2015-10-05 15:35:54 UTC) #3
Brian Wilkerson
5 years, 2 months ago (2015-10-05 16:20:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
04c5a5f199c6f0303a82baf6fc9452b12bbd6e16 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698