Clean up hints

pkg/analyzer/test/source/analysis_options_provider_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.source.analysis_options_provider;
 
 import 'package:analyzer/file_system/memory_file_system.dart';
 import 'package:analyzer/source/analysis_options_provider.dart';
 import 'package:unittest/unittest.dart';
 import 'package:yaml/yaml.dart';
@@ skipping 34 matching lines @@
     setUp(() {
       buildResourceProvider(true);
     });
     tearDown(() {
       clearResourceProvider();
     });
     test('test_empty', () {
       var optionsProvider = new AnalysisOptionsProvider();
       Map<String, YamlNode> options =
           optionsProvider.getOptions(resourceProvider.getFolder('/'));
+      expect(options, isNotNull);
     });
   });
   group('AnalysisOptionsProvider', () {
     setUp(() {
       buildResourceProvider(false, true);
     });
     tearDown(() {
       clearResourceProvider();
     });
     test('test_invalid', () {
       var optionsProvider = new AnalysisOptionsProvider();
       bool exceptionCaught = false;
       try {
         Map<String, YamlNode> options =
             optionsProvider.getOptions(resourceProvider.getFolder('/'));
-      } catch (e, st) {
+        expect(options, isNotNull);
+      } catch (e) {
         exceptionCaught = true;
       }
       expect(exceptionCaught, isTrue);
     });
   });
 }
 
 MemoryResourceProvider resourceProvider;
 
 buildResourceProvider([bool emptyAnalysisOptions = false,
@@ skipping 17 matching lines @@
   }
 }
 
 clearResourceProvider() {
   resourceProvider = null;
 }
 
 emptyResourceProvider() {
   resourceProvider = new MemoryResourceProvider();
 }