Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: pkg/analysis_server/lib/src/services/completion/completion_manager.dart

Issue 1382403002: Clean up hints (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/context/context.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/services/completion/completion_manager.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/completion_manager.dart
index ebc50542d87c3acc0e12a96a69041fd2e0964953..ca2e76cf8c7ce0c9472f41f17da34e65d3616fc2 100644
--- a/pkg/analysis_server/lib/src/services/completion/completion_manager.dart
+++ b/pkg/analysis_server/lib/src/services/completion/completion_manager.dart
@@ -273,11 +273,9 @@ class CompletionResultImpl implements CompletionResult {
CompletionResultImpl(this.replacementOffset, this.replacementLength,
this.suggestions, this.last);
- @override
- // TODO(brianwilkerson) Figure out whether this is correct.
- bool get hasNewSuggestions => suggestions.isNotEmpty;
-
- @override
+ /**
+ * Return `true` if this is the last completion result that will be produced.
+ */
bool get isLast => last;
}
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/context/context.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698