utils/pub/package.dart - Issue 13817008: Fix some warnings in pub and pkg packages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: utils/pub/package.dart

Issue 13817008: Fix some warnings in pub and pkg packages. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: utils/pub/package.dart

diff --git a/utils/pub/package.dart b/utils/pub/package.dart

index 39dde75fc77df2e311ab16a857ae8e2c892cf325..f1f65d30b41cea950dd6ff032e87a64f67d1de8a 100644

--- a/utils/pub/package.dart

+++ b/utils/pub/package.dart

@@ -46,7 +46,7 @@ class Package {

String get readmePath {

var readmes = listDir(dir).map(path.basename).

where((entry) => entry.contains(_README_REGEXP));

- if (readmes.isEmpty) return;

+ if (readmes.isEmpty) return null;

return path.join(dir, readmes.reduce((readme1, readme2) {

var extensions1 = ".".allMatches(readme1).length;

« no previous file with comments | « pkg/unittest/lib/unittest.dart ('k') | utils/pub/safe_http_server.dart » ('j') | no next file with comments »