Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: utils/pub/package.dart

Issue 13817008: Fix some warnings in pub and pkg packages. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « pkg/unittest/lib/unittest.dart ('k') | utils/pub/safe_http_server.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library package; 5 library package;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import 'package:pathos/path.dart' as path; 9 import 'package:pathos/path.dart' as path;
10 10
(...skipping 28 matching lines...) Expand all
39 List<PackageRef> get dependencies => pubspec.dependencies; 39 List<PackageRef> get dependencies => pubspec.dependencies;
40 40
41 /// Returns the path to the README file at the root of the entrypoint, or null 41 /// Returns the path to the README file at the root of the entrypoint, or null
42 /// if no README file is found. If multiple READMEs are found, this uses the 42 /// if no README file is found. If multiple READMEs are found, this uses the
43 /// same conventions as pub.dartlang.org for choosing the primary one: the 43 /// same conventions as pub.dartlang.org for choosing the primary one: the
44 /// README with the fewest extensions that is lexically ordered first is 44 /// README with the fewest extensions that is lexically ordered first is
45 /// chosen. 45 /// chosen.
46 String get readmePath { 46 String get readmePath {
47 var readmes = listDir(dir).map(path.basename). 47 var readmes = listDir(dir).map(path.basename).
48 where((entry) => entry.contains(_README_REGEXP)); 48 where((entry) => entry.contains(_README_REGEXP));
49 if (readmes.isEmpty) return; 49 if (readmes.isEmpty) return null;
50 50
51 return path.join(dir, readmes.reduce((readme1, readme2) { 51 return path.join(dir, readmes.reduce((readme1, readme2) {
52 var extensions1 = ".".allMatches(readme1).length; 52 var extensions1 = ".".allMatches(readme1).length;
53 var extensions2 = ".".allMatches(readme2).length; 53 var extensions2 = ".".allMatches(readme2).length;
54 var comparison = extensions1.compareTo(extensions2); 54 var comparison = extensions1.compareTo(extensions2);
55 if (comparison == 0) comparison = readme1.compareTo(readme2); 55 if (comparison == 0) comparison = readme1.compareTo(readme2);
56 return (comparison <= 0) ? readme1 : readme2; 56 return (comparison <= 0) ? readme1 : readme2;
57 })); 57 }));
58 } 58 }
59 59
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 229
230 class PubspecNameMismatchException implements Exception { 230 class PubspecNameMismatchException implements Exception {
231 final String expectedName; 231 final String expectedName;
232 final String actualName; 232 final String actualName;
233 233
234 PubspecNameMismatchException(this.expectedName, this.actualName); 234 PubspecNameMismatchException(this.expectedName, this.actualName);
235 235
236 String toString() => 'The name you specified for your dependency, ' 236 String toString() => 'The name you specified for your dependency, '
237 '"$expectedName", doesn\'t match the name "$actualName" in its pubspec.'; 237 '"$expectedName", doesn\'t match the name "$actualName" in its pubspec.';
238 } 238 }
OLDNEW
« no previous file with comments | « pkg/unittest/lib/unittest.dart ('k') | utils/pub/safe_http_server.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698