Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: pkg/unittest/lib/unittest.dart

Issue 13817008: Fix some warnings in pub and pkg packages. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/scheduled_test/lib/src/scheduled_server/safe_http_server.dart ('k') | utils/pub/package.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/unittest/lib/unittest.dart
diff --git a/pkg/unittest/lib/unittest.dart b/pkg/unittest/lib/unittest.dart
index ec792885b502ec49a5ac6046573a39f4018064a7..3bc7bb7d7883e8bd8b5c6cb88e300a2304abf881 100644
--- a/pkg/unittest/lib/unittest.dart
+++ b/pkg/unittest/lib/unittest.dart
@@ -201,11 +201,9 @@ String _currentGroup = '';
/** Separator used between group names and test names. */
String groupSep = ' ';
+// TODO(nweiz): present an unmodifiable view of this once issue 8321 is fixed.
/** Tests executed in this suite. */
-final List<TestCase> _testCases = new List<TestCase>();
-
-/** Get the list of tests. */
-final List<TestCase> testCases = new UnmodifiableListView(_testCases);
+final List<TestCase> testCases = new List<TestCase>();
/** Setup function called before each test in a group */
Function _testSetup;
« no previous file with comments | « pkg/scheduled_test/lib/src/scheduled_server/safe_http_server.dart ('k') | utils/pub/package.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698