Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1381633008: Merge to XFA: Pass v8::Isolate to PDFium at init time. (Closed)

Created:
5 years, 2 months ago by Tom Sepez
Modified:
5 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Pass v8::Isolate to PDFium at init time. New code changes in JS_Runtime.cpp. (cherry picked from commit 3dedace9623fef6161a8666e53a4ab2b9be61e4c) Original Review URL: https://codereview.chromium.org/1367033002 . Also merge to XFA: Run FXJS_V8 embedder tests against a shared isolate, since the two go together. (cherry picked from commit 4ea721cb7954898a9722c389dae86c62957352d0) Original Review URL: https://codereview.chromium.org/1377293004 . R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/a72e8e2c4392df725c7e35ed1ae3f891e79e49ec

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -66 lines) Patch
M fpdfsdk/include/jsapi/fxjs_v8.h View 1 1 chunk +6 lines, -1 line 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 2 chunks +5 lines, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 1 2 chunks +12 lines, -15 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 1 3 chunks +30 lines, -10 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp View 1 1 chunk +13 lines, -11 lines 2 comments Download
M public/fpdf_formfill.h View 1 chunk +5 lines, -10 lines 0 comments Download
M public/fpdfview.h View 2 chunks +12 lines, -1 line 0 comments Download
M samples/pdfium_test.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M testing/embedder_test.h View 4 chunks +7 lines, -2 lines 0 comments Download
M testing/embedder_test.cpp View 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Tom Sepez
Lei, small amount of new code here.
5 years, 2 months ago (2015-10-06 16:26:48 UTC) #1
Lei Zhang
lgtm https://codereview.chromium.org/1381633008/diff/20001/fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp File fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp (right): https://codereview.chromium.org/1381633008/diff/20001/fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp#newcode33 fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp:33: v8::Locker locker(m_pIsolate); BTW, we have |locker| here but ...
5 years, 2 months ago (2015-10-06 23:18:55 UTC) #2
Tom Sepez
> BTW, we have |locker| here but not on the main branch. > I've always ...
5 years, 2 months ago (2015-10-06 23:22:50 UTC) #3
Tom Sepez
5 years, 2 months ago (2015-10-07 17:17:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a72e8e2c4392df725c7e35ed1ae3f891e79e49ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698