Pass v8::Isolate to PDFium at init time.

Pass v8::Isolate to PDFium at init time.

Move the external isolate and embedder slot from the
IPDF_JSPlatforms struct supplied at the
FPDFDOC_InitFormFillEnvironment() call time to arguments to
the FPDF_InitLibraryWithConfig() call.

This has several benefits:
-- Avoids the crash that could happen if multiple
FPDFDOC_InitFormFillEnvironmen() calls should happen to be
made by an embedder with different slot values.
-- Down the road, for XFA, there may be XFA but no FormFill
environment.

We support both forms for the time being, until the chrome
side catches up, at which point we will deprecate the old
way.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/3dedace9623fef6161a8666e53a4ab2b9be61e4c

[Tom Sepez, 2015-09-29 16:00:46]

tsepez@chromium.org changed reviewers:
+ jochen@chromium.org, raymes@chromium.org, thestig@chromium.org

[Tom Sepez, 2015-09-29 16:00:47]

For discussion purposes.

[raymes, 2015-09-30 01:21:43]

Hey Tom, could you explain this a bit? Does it solve the problem of freeing the
per-isolate data too early?

From what I can tell, the problem is that we're releasing the per isolate data
in ~CJS_Runtime but that destructor gets called everytime an instance/document
is destroyed. Instead we want to release the per isolate data once per process
(see the notes on https://code.google.com/p/chromium/issues/detail?id=531339)

[raymes, 2015-09-30 01:22:19]

Ohh sorry I just saw your notes in the bug :) I see it's not complete.

[Tom Sepez, 2015-10-02 18:14:27]

Ready for review: jochen, thestig, raymes.

[Lei Zhang, 2015-10-02 22:02:16]

https://codereview.chromium.org/1367033002/diff/110001/fpdfsdk/include/javasc...
File fpdfsdk/include/javascript/JS_Runtime.h (right):

https://codereview.chromium.org/1367033002/diff/110001/fpdfsdk/include/javasc...
fpdfsdk/include/javascript/JS_Runtime.h:13: #include
"../../../third_party/base/nonstd_unique_ptr.h"
nit: Remove as well?

https://codereview.chromium.org/1367033002/diff/110001/fpdfsdk/include/javasc...
fpdfsdk/include/javascript/JS_Runtime.h:15: #include "../jsapi/fxjs_v8.h"
Also remove I think?

https://codereview.chromium.org/1367033002/diff/110001/fpdfsdk/src/fpdfview.cpp
File fpdfsdk/src/fpdfview.cpp (right):

https://codereview.chromium.org/1367033002/diff/110001/fpdfsdk/src/fpdfview.c...
fpdfsdk/src/fpdfview.cpp:113: if (cfg && cfg->version >= 2) {
Do we want to nag callers using API version 1, or any other unknown version?

https://codereview.chromium.org/1367033002/diff/110001/fpdfsdk/src/javascript...
File fpdfsdk/src/javascript/JS_Runtime.cpp (right):

https://codereview.chromium.org/1367033002/diff/110001/fpdfsdk/src/javascript...
fpdfsdk/src/javascript/JS_Runtime.cpp:39: if (pPlatform->version <= 2) {
Can you mention this is the deprecated way and mark it for future removal?

Or even print an annoying message so PDFium users notice that this is the
deprecated way?

[Tom Sepez, 2015-10-02 22:46:50]

https://codereview.chromium.org/1367033002/diff/110001/fpdfsdk/include/javasc...
File fpdfsdk/include/javascript/JS_Runtime.h (right):

https://codereview.chromium.org/1367033002/diff/110001/fpdfsdk/include/javasc...
fpdfsdk/include/javascript/JS_Runtime.h:13: #include
"../../../third_party/base/nonstd_unique_ptr.h"
On 2015/10/02 22:02:15, Lei Zhang wrote:
> nit: Remove as well?

Done.

https://codereview.chromium.org/1367033002/diff/110001/fpdfsdk/include/javasc...
fpdfsdk/include/javascript/JS_Runtime.h:15: #include "../jsapi/fxjs_v8.h"
On 2015/10/02 22:02:15, Lei Zhang wrote:
> Also remove I think?
Sorry, can't remove.  This is how fpdfsdk/include/javascript files learn about
v8-isms that have leaked out of fxjs, like the isolate below.

https://codereview.chromium.org/1367033002/diff/110001/fpdfsdk/src/fpdfview.cpp
File fpdfsdk/src/fpdfview.cpp (right):

https://codereview.chromium.org/1367033002/diff/110001/fpdfsdk/src/fpdfview.c...
fpdfsdk/src/fpdfview.cpp:113: if (cfg && cfg->version >= 2) {
On 2015/10/02 22:02:15, Lei Zhang wrote:
> Do we want to nag callers using API version 1, or any other unknown version?

I want to continue to seamlessly support those embedders that rely on pdfium to
create their isolates.  There's no reason for them to move ahead just yet.

https://codereview.chromium.org/1367033002/diff/110001/fpdfsdk/src/javascript...
File fpdfsdk/src/javascript/JS_Runtime.cpp (right):

https://codereview.chromium.org/1367033002/diff/110001/fpdfsdk/src/javascript...
fpdfsdk/src/javascript/JS_Runtime.cpp:39: if (pPlatform->version <= 2) {
On 2015/10/02 22:02:15, Lei Zhang wrote:
> Can you mention this is the deprecated way and mark it for future removal?
> 
> Or even print an annoying message so PDFium users notice that this is the
> deprecated way?
Oh yes, once chrome catches up, using v2 is going to abort.  You need to use v1
or v3, which are the same struct, but v1 triggers the initialization for the
compatibility reason mentioned before.

[Lei Zhang, 2015-10-02 23:18:51]

Sounds good, lgtm

[Tom Sepez, 2015-10-02 23:43:20]

Committed patchset #8 (id:130001) manually as
3dedace9623fef6161a8666e53a4ab2b9be61e4c (presubmit successful).