Run FXJS_V8 embedder tests against a shared isolate.

Run FXJS_V8 embedder tests against a shared isolate.

Start to back-fill some tests for the recent isolate work.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/4ea721cb7954898a9722c389dae86c62957352d0

[Tom Sepez, 2015-10-05 18:43:32]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-10-05 18:43:32]

Lei, for review.

[Tom Sepez, 2015-10-05 20:17:51]

https://codereview.chromium.org/1377293004/diff/20001/fpdfsdk/src/jsapi/fxjs_...
File fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp (right):

https://codereview.chromium.org/1377293004/diff/20001/fpdfsdk/src/jsapi/fxjs_...
fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp:25:
EmbedderTest::SetDelegate(m_pDelegate.get());
Question:  Is this worth adding to the delegate, or should the embedderTest
itself just have a SetIsolate method?

[Tom Sepez, 2015-10-05 20:52:10]

Yeah, PS2 cleaner.  PTAL.

[Tom Sepez, 2015-10-05 20:57:03]

On 2015/10/05 20:52:10, Tom Sepez wrote:
> Yeah, PS2 cleaner.  PTAL.
Where by PS2, I mean PS3.

[Lei Zhang, 2015-10-06 01:36:43]

lgtm

https://codereview.chromium.org/1377293004/diff/40001/testing/embedder_test.h
File testing/embedder_test.h (right):

https://codereview.chromium.org/1377293004/diff/40001/testing/embedder_test.h...
testing/embedder_test.h:64: // Call before SetUp to pass shared isolate,
otherwise PDFium creates one.
And if PDFium already created one, calling this is an error, right? Do you think
it's worth checking for?

[Tom Sepez, 2015-10-06 15:50:14]

https://codereview.chromium.org/1377293004/diff/40001/testing/embedder_test.h
File testing/embedder_test.h (right):

https://codereview.chromium.org/1377293004/diff/40001/testing/embedder_test.h...
testing/embedder_test.h:64: // Call before SetUp to pass shared isolate,
otherwise PDFium creates one.
On 2015/10/06 01:36:43, Lei Zhang wrote:
> And if PDFium already created one, calling this is an error, right? Do you
think
> it's worth checking for?
That would require adding additional state here just to assert; part of the
problem is that the isolate is hidden in globals in FXJS without a corresponding
object returned to its callers.  So I'm not sure its worth it until FXJS gets
cleaner.

[Tom Sepez, 2015-10-06 15:53:17]

Committed patchset #4 (id:60001) manually as
4ea721cb7954898a9722c389dae86c62957352d0 (presubmit successful).

[jochen (gone - plz use gerrit), 2015-11-20 08:39:46]

jochen@chromium.org changed reviewers:
+ jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-11-20 08:39:47]

https://codereview.chromium.org/1377293004/diff/60001/fpdfsdk/src/jsapi/fxjs_...
File fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp (right):

https://codereview.chromium.org/1377293004/diff/60001/fpdfsdk/src/jsapi/fxjs_...
fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp:23: m_pIsolate =
v8::Isolate::New(params);
this creates an isolate before v8 is initialized in EmbedderTest::SetUp