Issue 1381603003: Mac Overlays: Clip display and UV rects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1381603003: Mac Overlays: Clip display and UV rects (Closed)

Created:
5 years, 2 months ago by ccameron

Modified:
5 years, 2 months ago

Reviewers:

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2490

Target Ref:
refs/pending/branch-heads/2490

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mac Overlays: Clip display and UV rects Make the Mac-specific sandwich strategy apply clipping to the display rectangle. Apply the same relative clipping to the uv rectangle. Add unit tests, and move code around to improve readability. BUG=536854 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1370363002 Cr-Commit-Position: refs/heads/master@{#351312} (cherry picked from commit e790d9f582a00168faf0aa81f6fe5477848bec2b) Committed: https://chromium.googlesource.com/chromium/src/+/21a4f7e7e56823e74997fb64b57a80bc619506be

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -10 lines)			Patch
M	cc/output/overlay_strategy_common.cc	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	cc/output/overlay_strategy_sandwich.cc	View	4 chunks	+34 lines, -9 lines	0 comments	Download
M	cc/output/overlay_unittest.cc	View	1 chunk	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ccameron

Committed patchset #1 (id:1) manually as 21a4f7e7e56823e74997fb64b57a80bc619506be.

5 years, 2 months ago (2015-10-01 21:28:13 UTC) #1

ccameron

5 years, 2 months ago (2015-10-01 22:07:24 UTC) #2

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1384583003/ by ccameron@chromium.org.

The reason for reverting is: Breaks compile..

Expand Messages | Collapse Messages