Chromium Code Reviews

Issue 1157333005: [net/http auth] Use strings to identify authentication schemes.

Created:
5 years, 6 months ago by asanka
Modified:
5 years, 2 months ago
Reviewers:
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[net/http auth] Use strings to identify authentication schemes. While the network stack allowed registration of arbitrary authentication schemes, the authentication logic relied on being able to use the HttpAuth::Scheme enumeration to uniquely identify each scheme. In practice, this restricted the list of supported authentication schemes to those that were well known and supported by the network stack. This change allows the use of any RFC 7235 compliant scheme for an authentication handler. It also consolidates the determination of relative priorities. Previously, even though HttpAuthHandlers could be implemented externally to //net, they had to expose a priority score that's in reality an implementation detail of supported authentication schemes. In addition, consolidation of authentication handler priorities alows HttpAuth to score authentication challenge headers without constructing HttpAuthHandlers for each header. BUG=270219 BUG=529321

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Stats (+519 lines, -464 lines)
M chrome/browser/chromeos/login/profile_auth_data_unittest.cc View 3 chunks +9 lines, -12 lines 0 comments
M content/browser/media/android/media_resource_getter_impl.cc View 1 chunk +1 line, -1 line 0 comments
M net/base/auth.h View 2 chunks +3 lines, -2 lines 0 comments
M net/http/http_auth.h View 5 chunks +15 lines, -24 lines 0 comments
M net/http/http_auth.cc View 4 chunks +90 lines, -34 lines 0 comments
M net/http/http_auth_cache.h View 5 chunks +14 lines, -13 lines 0 comments
M net/http/http_auth_cache.cc View 5 chunks +9 lines, -8 lines 0 comments
M net/http/http_auth_cache_unittest.cc View 19 chunks +56 lines, -100 lines 0 comments
M net/http/http_auth_challenge_tokenizer.h View 1 chunk +10 lines, -4 lines 0 comments
M net/http/http_auth_challenge_tokenizer.cc View 2 chunks +15 lines, -0 lines 0 comments
M net/http/http_auth_challenge_tokenizer_unittest.cc View 10 chunks +22 lines, -10 lines 0 comments
M net/http/http_auth_controller.h View 3 chunks +4 lines, -3 lines 0 comments
M net/http/http_auth_controller.cc View 6 chunks +46 lines, -11 lines 0 comments
M net/http/http_auth_controller_unittest.cc View 7 chunks +35 lines, -45 lines 0 comments
M net/http/http_auth_handler.h View 6 chunks +4 lines, -37 lines 0 comments
M net/http/http_auth_handler.cc View 2 chunks +7 lines, -14 lines 0 comments
M net/http/http_auth_handler_basic.cc View 2 chunks +4 lines, -4 lines 0 comments
M net/http/http_auth_handler_digest.cc View 4 chunks +5 lines, -5 lines 0 comments
M net/http/http_auth_handler_digest_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments
M net/http/http_auth_handler_factory.h View 1 chunk +2 lines, -2 lines 0 comments
M net/http/http_auth_handler_factory.cc View 2 chunks +5 lines, -6 lines 0 comments
M net/http/http_auth_handler_factory_unittest.cc View 7 chunks +7 lines, -15 lines 0 comments
M net/http/http_auth_handler_mock.h View 3 chunks +15 lines, -9 lines 0 comments
M net/http/http_auth_handler_mock.cc View 4 chunks +12 lines, -17 lines 0 comments
M net/http/http_auth_handler_negotiate.cc View 2 chunks +3 lines, -3 lines 0 comments
M net/http/http_auth_handler_ntlm.cc View 2 chunks +2 lines, -5 lines 0 comments
M net/http/http_auth_multi_round_parse.cc View 2 chunks +2 lines, -15 lines 0 comments
A net/http/http_auth_scheme_set.h View 1 chunk +33 lines, -0 lines 0 comments
A net/http/http_auth_scheme_set.cc View 1 chunk +26 lines, -0 lines 0 comments
M net/http/http_auth_unittest.cc View 5 chunks +41 lines, -41 lines 0 comments
M net/http/http_log_util.cc View 1 chunk +1 line, -1 line 0 comments
M net/http/http_network_transaction_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments
M net/http/http_proxy_client_socket_pool_unittest.cc View 1 chunk +2 lines, -5 lines 0 comments
M net/log/net_log_event_type_list.h View 1 chunk +7 lines, -0 lines 0 comments
M net/net.gypi View 1 chunk +2 lines, -0 lines 0 comments
M net/socket/ssl_client_socket_pool_unittest.cc View 1 chunk +3 lines, -6 lines 0 comments
M net/spdy/spdy_proxy_client_socket_unittest.cc View 1 chunk +2 lines, -5 lines 0 comments
M net/url_request/url_request_context_builder_unittest.cc View 1 chunk +1 line, -1 line 0 comments

Powered by Google App Engine