Issue 1381373002: Merge 3 CLs required to fix bug 536917:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1381373002: Merge 3 CLs required to fix bug 536917: (Closed)

Created:
5 years, 2 months ago by Martin Barbella

Modified:
5 years, 2 months ago

Reviewers:
Oliver Chang, Oliver Chang (dont use)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2490

Target Ref:
refs/pending/branch-heads/2490

Project:
chromium

Visibility:
Public.

Merge 3 CLs required to fix bug 536917: Oilpan: Fix build after 7338ad63. Review URL: https://codereview.chromium.org/1379463002 Cr-Commit-Position: refs/heads/master@{#351255} (cherry picked from commit 2c4017042ecfa61efc1dfbc8bed52d044b353def) Properly fix use-after-free of InputTypeViews when the type attribute is modified in the change event handler. Follow-up to https://codereview.chromium.org/1366983003/ Review URL: https://codereview.chromium.org/1377673002 Cr-Commit-Position: refs/heads/master@{#351244} (cherry picked from commit 7338ad634e98e80404df1fa0ea5dd2d198dbdd95) Prevent CheckboxInputType from being freed by change event handlers. Review URL: https://codereview.chromium.org/1366983003 Cr-Commit-Position: refs/heads/master@{#350787} (cherry picked from commit 78501ccabe3e33db6f051f673d31caefe81be4a0) BUG=536917 R=ochang@chromium.org TBR=ochang@google.com Committed: https://chromium.googlesource.com/chromium/src/+/19a48e8fef901572e29f16e7e027324f6f604293

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -0 lines)			Patch
A	third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-change-event-free.html	View	1 chunk	+14 lines, -0 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-change-event-free-expected.txt	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/html/HTMLInputElement.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 3 (1 generated)

Martin Barbella

5 years, 2 months ago (2015-10-02 22:08:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
19a48e8fef901572e29f16e7e027324f6f604293.