Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1366983003: Prevent CheckboxInputType from being freed by change event handlers. (Closed)

Created:
5 years, 2 months ago by Oliver Chang
Modified:
5 years, 2 months ago
Reviewers:
tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent CheckboxInputType from being freed by change event handlers. BUG=534990 R=tkent@chromium.org Committed: https://crrev.com/78501ccabe3e33db6f051f673d31caefe81be4a0 Cr-Commit-Position: refs/heads/master@{#350787}

Patch Set 1 #

Patch Set 2 : testcase #

Total comments: 2

Patch Set 3 : fix tests #

Total comments: 2

Patch Set 4 : fix tests again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-change-event-free.html View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-change-event-free-expected.txt View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/CheckboxInputType.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (1 generated)
Oliver Chang
ptal
5 years, 2 months ago (2015-09-24 22:28:20 UTC) #1
tkent
Thank you for working on this issue. Please add a test.
5 years, 2 months ago (2015-09-24 23:09:41 UTC) #2
Oliver Chang
On 2015/09/24 23:09:41, tkent wrote: > Thank you for working on this issue. > Please ...
5 years, 2 months ago (2015-09-24 23:13:17 UTC) #3
tkent
On 2015/09/24 at 23:13:17, ochang wrote: > On 2015/09/24 23:09:41, tkent wrote: > > Thank ...
5 years, 2 months ago (2015-09-24 23:50:47 UTC) #4
Oliver Chang
On 2015/09/24 23:50:47, tkent wrote: > On 2015/09/24 at 23:13:17, ochang wrote: > > On ...
5 years, 2 months ago (2015-09-25 00:02:30 UTC) #5
tkent
https://codereview.chromium.org/1366983003/diff/20001/third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-change-event-free.html File third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-change-event-free.html (right): https://codereview.chromium.org/1366983003/diff/20001/third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-change-event-free.html#newcode1 third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-change-event-free.html:1: <!DOCTYPE html> This is a pixel test unnecessarily. Please ...
5 years, 2 months ago (2015-09-25 00:44:45 UTC) #6
Oliver Chang
https://codereview.chromium.org/1366983003/diff/20001/third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-change-event-free.html File third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-change-event-free.html (right): https://codereview.chromium.org/1366983003/diff/20001/third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-change-event-free.html#newcode1 third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-change-event-free.html:1: <!DOCTYPE html> On 2015/09/25 00:44:45, tkent wrote: > This ...
5 years, 2 months ago (2015-09-25 04:06:04 UTC) #7
tkent
almost ok. https://codereview.chromium.org/1366983003/diff/40001/third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-change-event-free.html File third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-change-event-free.html (right): https://codereview.chromium.org/1366983003/diff/40001/third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-change-event-free.html#newcode12 third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-change-event-free.html:12: </script> Let's add what's the expected behavior. ...
5 years, 2 months ago (2015-09-25 04:35:13 UTC) #8
Oliver Chang
https://codereview.chromium.org/1366983003/diff/40001/third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-change-event-free.html File third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-change-event-free.html (right): https://codereview.chromium.org/1366983003/diff/40001/third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-change-event-free.html#newcode12 third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-change-event-free.html:12: </script> On 2015/09/25 04:35:13, tkent wrote: > Let's add ...
5 years, 2 months ago (2015-09-25 04:48:34 UTC) #9
tkent
lgtm
5 years, 2 months ago (2015-09-25 04:49:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1366983003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1366983003/60001
5 years, 2 months ago (2015-09-25 04:49:25 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-09-25 08:18:55 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 08:20:02 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/78501ccabe3e33db6f051f673d31caefe81be4a0
Cr-Commit-Position: refs/heads/master@{#350787}

Powered by Google App Engine
This is Rietveld 408576698