Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1377673002: Properly fix use-after-free of InputTypeViews when the type attribute is modified in the change eve… (Closed)

Created:
5 years, 2 months ago by Oliver Chang
Modified:
5 years, 2 months ago
Reviewers:
tkent, esprehn
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Properly fix use-after-free of InputTypeViews when the type attribute is modified in the change event handler. Follow-up to https://codereview.chromium.org/1366983003/ R=tkent@chromium.org,esprehn@chromium.org BUG=536917 Committed: https://crrev.com/7338ad634e98e80404df1fa0ea5dd2d198dbdd95 Cr-Commit-Position: refs/heads/master@{#351244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/CheckboxInputType.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Oliver Chang
ptal.
5 years, 2 months ago (2015-09-28 22:58:20 UTC) #1
esprehn
lgtm
5 years, 2 months ago (2015-09-28 23:15:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377673002/1
5 years, 2 months ago (2015-09-28 23:21:14 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/126614)
5 years, 2 months ago (2015-09-28 23:47:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377673002/1
5 years, 2 months ago (2015-09-29 00:01:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 02:29:24 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7338ad634e98e80404df1fa0ea5dd2d198dbdd95 Cr-Commit-Position: refs/heads/master@{#351244}
5 years, 2 months ago (2015-09-29 02:30:36 UTC) #10
Lei Zhang
5 years, 2 months ago (2015-09-29 02:47:01 UTC) #11
Message was sent while issue was closed.
BTW, this broke oilpan, and oilpan is now on the main waterfall, but without
trybots.

Powered by Google App Engine
This is Rietveld 408576698