Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: components/autofill/content/renderer/password_autofill_agent.h

Issue 1381003004: Better distinguish didFinishLoad and didStopLoading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_autofill_agent.h
diff --git a/components/autofill/content/renderer/password_autofill_agent.h b/components/autofill/content/renderer/password_autofill_agent.h
index af38bf5e6273728563cffb8807b4dd54eafa5ab6..69f2bb5e61a3897ace757d4d787d449553ecbf74 100644
--- a/components/autofill/content/renderer/password_autofill_agent.h
+++ b/components/autofill/content/renderer/password_autofill_agent.h
@@ -151,8 +151,6 @@ class PasswordAutofillAgent : public content::RenderFrameObserver {
// RenderViewObserver:
void OnDestruct() override;
- void DidStartLoading() override;
- void DidStopLoading() override;
void DidStartProvisionalLoad(blink::WebLocalFrame* frame) override;
private:
@@ -174,8 +172,6 @@ class PasswordAutofillAgent : public content::RenderFrameObserver {
void WillSubmitForm(const blink::WebFormElement& form) override;
// Legacy RenderViewObserver:
- void DidStartLoading();
- void DidStopLoading();
void LegacyDidStartProvisionalLoad(blink::WebLocalFrame* frame);
// RenderView IPC handlers:
@@ -269,9 +265,6 @@ class PasswordAutofillAgent : public content::RenderFrameObserver {
// Records the username typed before suggestions preview.
base::string16 username_query_prefix_;
- // True indicates that all frames in a page have been rendered.
- bool did_stop_loading_;
-
// Contains server predictions for username, password and/or new password
// fields for individual forms.
FormsPredictionsMap form_predictions_;

Powered by Google App Engine
This is Rietveld 408576698