Better distinguish didFinishLoad and didStopLoading

components/autofill/content/renderer/password_autofill_agent.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_
 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_
 
 #include <map>
 #include <vector>
 
@@ skipping 133 matching lines @@
   // to RenderFrameObserver. Should eventually be removed.
   // http://crbug.com/433486
   class LegacyPasswordAutofillAgent : public content::RenderViewObserver {
    public:
     LegacyPasswordAutofillAgent(content::RenderView* render_view,
                                 PasswordAutofillAgent* agent);
     ~LegacyPasswordAutofillAgent() override;
 
     // RenderViewObserver:
     void OnDestruct() override;
-    void DidStartLoading() override;
-    void DidStopLoading() override;
     void DidStartProvisionalLoad(blink::WebLocalFrame* frame) override;
 
    private:
     PasswordAutofillAgent* agent_;
 
     DISALLOW_COPY_AND_ASSIGN(LegacyPasswordAutofillAgent);
   };
   friend class LegacyPasswordAutofillAgent;
 
   // RenderFrameObserver:
   bool OnMessageReceived(const IPC::Message& message) override;
   void DidFinishDocumentLoad() override;
   void DidFinishLoad() override;
   void FrameDetached() override;
   void FrameWillClose() override;
   void DidCommitProvisionalLoad(bool is_new_navigation,
                                 bool is_same_page_navigation) override;
   void WillSendSubmitEvent(const blink::WebFormElement& form) override;
   void WillSubmitForm(const blink::WebFormElement& form) override;
 
   // Legacy RenderViewObserver:
-  void DidStartLoading();
-  void DidStopLoading();
   void LegacyDidStartProvisionalLoad(blink::WebLocalFrame* frame);
 
   // RenderView IPC handlers:
   void OnFillPasswordForm(int key, const PasswordFormFillData& form_data);
   void OnSetLoggingState(bool active);
   void OnAutofillUsernameAndPasswordDataReceived(
       const FormsPredictionsMap& predictions);
   void OnFindFocusedPasswordForm();
 
   // Scans the given frame for password forms and sends them up to the browser.
@@ skipping 73 matching lines @@
   bool logging_state_active_;
 
   // True indicates that the username field was autofilled, false otherwise.
   bool was_username_autofilled_;
   // True indicates that the password field was autofilled, false otherwise.
   bool was_password_autofilled_;
 
   // Records the username typed before suggestions preview.
   base::string16 username_query_prefix_;
 
-  // True indicates that all frames in a page have been rendered.
-  bool did_stop_loading_;
-
   // Contains server predictions for username, password and/or new password
   // fields for individual forms.
   FormsPredictionsMap form_predictions_;
 
   base::WeakPtrFactory<PasswordAutofillAgent> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordAutofillAgent);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_