chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/TabLoadObserver.java - Issue 1381003004: Better distinguish didFinishLoad and didStopLoading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/TabLoadObserver.java

Issue 1381003004: Better distinguish didFinishLoad and didStopLoading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_navigation/web_navigation_api.cc ('k') | components/autofill/content/renderer/password_autofill_agent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/TabLoadObserver.java

diff --git a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/TabLoadObserver.java b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/TabLoadObserver.java

index 0e0ce2c009eaa8bddc799f0a7df13c364c69e93c..ca1b0429fc2e8566128f93a97e8e1a1fd5dc0006 100644

--- a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/TabLoadObserver.java

+++ b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/TabLoadObserver.java

@@ -44,12 +44,12 @@ public class TabLoadObserver extends EmptyTabObserver implements Criteria {

}

@Override

- public void onLoadStarted(Tab tab) {

+ public void onLoadStarted(Tab tab, boolean toDifferentDocument) {

mTabLoadStarted = true;

}

@Override

- public void onLoadStopped(Tab tab) {

+ public void onLoadStopped(Tab tab, boolean toDifferentDocument) {

mTabLoadStopped = true;

}

@@ -70,4 +70,4 @@ public class TabLoadObserver extends EmptyTabObserver implements Criteria {

}

return true;

}