Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1380613002: Fix bugs in impl/memory queries. (Closed)

Created:
5 years, 2 months ago by iannucci
Modified:
5 years, 2 months ago
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae.git@add_appid
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Fix bugs in impl/memory queries. This prevents built-in indexes from being selected when using ancestor and non-__key__ inequality filters, and also fixes a bug where a multi-iterator on builtin indexes using __key__ inequality with ancestor would return empty result sets. R=dnj@chromium.org, estaab@chromium.org, maruel@chromium.org, tandrii@chromium.org, vadimsh@chromium.org BUG= Committed: https://github.com/luci/gae/commit/7e4e3b08d5f88ed95fca2aea615dd40aaad48d17

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -26 lines) Patch
M impl/memory/datastore_index_selection.go View 2 chunks +10 lines, -15 lines 0 comments Download
M impl/memory/datastore_query_execution.go View 1 chunk +1 line, -1 line 0 comments Download
M impl/memory/datastore_query_execution_test.go View 3 chunks +62 lines, -8 lines 0 comments Download
M impl/memory/gkvlite_iter.go View 2 chunks +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1369353003 Patch 1

Dependent Patchsets:

Issue 1379673002 Patch 1

Messages

Total messages: 5 (1 generated)
iannucci
5 years, 2 months ago (2015-09-29 19:51:23 UTC) #1
Vadim Sh.
lgtm
5 years, 2 months ago (2015-09-30 00:37:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380613002/1
5 years, 2 months ago (2015-09-30 00:40:04 UTC) #4
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 00:43:00 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/7e4e3b08d5f88ed95fca2aea615dd40aaad48d17

Powered by Google App Engine
This is Rietveld 408576698