Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1369353003: Make impl/memory have an AppID. (Closed)

Created:
5 years, 2 months ago by iannucci
Modified:
5 years, 2 months ago
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae.git@fix_consistent
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Make impl/memory have an AppID. This associates an immutable AppID with the datastoreData object (e.g. the thing that actually holds the data). It gets rid of the hard-coded globalAppID hack. R=dnj@chromium.org, estaab@chromium.org, maruel@chromium.org, tandrii@chromium.org, vadimsh@chromium.org BUG= Committed: https://github.com/luci/gae/commit/ceaf368d0c901794286120efdb98974c47b8ddc0

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -96 lines) Patch
M impl/memory/context.go View 2 chunks +15 lines, -7 lines 0 comments Download
M impl/memory/datastore.go View 2 chunks +6 lines, -6 lines 0 comments Download
M impl/memory/datastore_data.go View 7 chunks +10 lines, -10 lines 0 comments Download
M impl/memory/datastore_index.go View 2 chunks +3 lines, -3 lines 0 comments Download
M impl/memory/datastore_index_selection.go View 3 chunks +3 lines, -2 lines 0 comments Download
M impl/memory/datastore_query.go View 2 chunks +52 lines, -42 lines 2 comments Download
M impl/memory/datastore_query_execution.go View 6 chunks +12 lines, -11 lines 0 comments Download
M impl/memory/datastore_query_test.go View 4 chunks +4 lines, -4 lines 0 comments Download
M impl/memory/info.go View 2 chunks +5 lines, -10 lines 0 comments Download
M impl/memory/testing_utils_test.go View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (1 generated)
iannucci
5 years, 2 months ago (2015-09-29 19:41:18 UTC) #1
Vadim Sh.
lgtm https://codereview.chromium.org/1369353003/diff/1/impl/memory/datastore_query.go File impl/memory/datastore_query.go (right): https://codereview.chromium.org/1369353003/diff/1/impl/memory/datastore_query.go#newcode105 impl/memory/datastore_query.go:105: // GetBinaryBounds gets the binary encoding of the ...
5 years, 2 months ago (2015-09-29 19:52:28 UTC) #2
iannucci
https://codereview.chromium.org/1369353003/diff/1/impl/memory/datastore_query.go File impl/memory/datastore_query.go (right): https://codereview.chromium.org/1369353003/diff/1/impl/memory/datastore_query.go#newcode105 impl/memory/datastore_query.go:105: // GetBinaryBounds gets the binary encoding of the upper ...
5 years, 2 months ago (2015-09-29 20:04:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369353003/1
5 years, 2 months ago (2015-09-29 20:05:14 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 20:07:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/ceaf368d0c901794286120efdb98974c47b8ddc0

Powered by Google App Engine
This is Rietveld 408576698