Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1379673002: Add a NewDatastore helper function. (Closed)

Created:
5 years, 2 months ago by iannucci
Modified:
5 years, 2 months ago
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae.git@fix_queries
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -0 lines) Patch
M impl/memory/datastore.go View 2 chunks +24 lines, -0 lines 3 comments Download
M impl/memory/datastore_test.go View 1 chunk +26 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1380613002 Patch 1

Dependent Patchsets:

Issue 1309803004 Patch 220001

Messages

Total messages: 7 (1 generated)
iannucci
5 years, 2 months ago (2015-09-29 20:04:15 UTC) #1
Vadim Sh.
lgtm https://codereview.chromium.org/1379673002/diff/1/impl/memory/datastore.go File impl/memory/datastore.go (right): https://codereview.chromium.org/1379673002/diff/1/impl/memory/datastore.go#newcode49 impl/memory/datastore.go:49: t := ret.Testable() name 'Testable' is unfortunate, considering ...
5 years, 2 months ago (2015-09-29 20:08:36 UTC) #2
iannucci
https://codereview.chromium.org/1379673002/diff/1/impl/memory/datastore.go File impl/memory/datastore.go (right): https://codereview.chromium.org/1379673002/diff/1/impl/memory/datastore.go#newcode49 impl/memory/datastore.go:49: t := ret.Testable() On 2015/09/29 at 20:08:36, Vadim Sh. ...
5 years, 2 months ago (2015-09-29 20:09:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379673002/1
5 years, 2 months ago (2015-09-29 20:09:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://github.com/luci/gae/commit/c328fc9a87f03daae1cbee320f3f37b6bc765f16
5 years, 2 months ago (2015-09-29 20:11:06 UTC) #6
Vadim Sh.
5 years, 2 months ago (2015-09-29 20:12:04 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1379673002/diff/1/impl/memory/datastore.go
File impl/memory/datastore.go (right):

https://codereview.chromium.org/1379673002/diff/1/impl/memory/datastore.go#ne...
impl/memory/datastore.go:49: t := ret.Testable()
On 2015/09/29 20:09:45, iannucci wrote:
> On 2015/09/29 at 20:08:36, Vadim Sh. wrote:
> > name 'Testable' is unfortunate, considering it is used in prod code now
> 
> Yeah that occurred to me. AlterSemantics?

"Tweaks"? "Hacks"? :)

Powered by Google App Engine
This is Rietveld 408576698