Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 1380323002: Make registration.update() no longer force bypassing the HTTP cache (Closed)

Created:
5 years, 2 months ago by jungkees
Modified:
5 years, 2 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, falken, darin-cc_chromium.org, blink-reviews, horo+watch_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make registration.update() no longer force bypassing the HTTP cache As per the last f2f and the follow-up discussion, ServiceWorkerRegistration.update() should not always bypass the HTTP cache but bypass it only when 24 hours have passed since the last update check. So, this patch involves a change in the behavior of ServiceWorkerRegistration.update(). Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-registration-update Spec discussion: https://github.com/slightlyoff/ServiceWorker/issues/514#issuecomment-130664373 This CL merged two CLs that were created and under review before Blink and Chromium repos were merged: 1. Blink: https://codereview.chromium.org/1332303002/ 2. Chromium: https://codereview.chromium.org/1339623002/ BUG=530540 Committed: https://crrev.com/395e4a2444b1e74c753cde3eb4de342e57bb2915 Cr-Commit-Position: refs/heads/master@{#352232}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
jungkees
I made this new patch to land https://codereview.chromium.org/1332303002 and https://codereview.chromium.org/1339623002 as a single CL. PTAL
5 years, 2 months ago (2015-10-02 13:56:07 UTC) #2
falken
lgtm
5 years, 2 months ago (2015-10-02 14:04:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380323002/1
5 years, 2 months ago (2015-10-03 02:18:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-03 03:36:37 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-03 03:37:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/395e4a2444b1e74c753cde3eb4de342e57bb2915
Cr-Commit-Position: refs/heads/master@{#352232}

Powered by Google App Engine
This is Rietveld 408576698