Make registration.update() no longer force bypassing the HTTP cache (2/2)

Make registration.update() no longer force bypassing the HTTP cache (2/2)

As per the last f2f and the follow-up discussion,
ServiceWorkerRegistration.update() should not always bypass the HTTP cache but
bypass it only when 24 hours have passed since the last update check. So, this
patch involves a change in the behavior of ServiceWorkerRegistration.update().

Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-registration-update
Spec discussion: https://github.com/slightlyoff/ServiceWorker/issues/514#issuecomment-130664373

Companion CL (Blink layout test): https://codereview.chromium.org/1332303002/

BUG=530540

[jungkees, 2015-09-11 11:36:27]

jungkee.song@samsung.com changed reviewers:
+ jinho.bang@samsung.com, l.gombos@samsung.com

[jungkees, 2015-09-11 11:45:03]

This patch is split from https://codereview.chromium.org/1283273002/, and the
part that addresses registration.update()'s behavior change. (See #msg31). PTAL

[zino, 2015-09-11 11:51:48]

non-owner lgtm.

[jungkees, 2015-09-11 11:55:56]

jungkee.song@samsung.com changed reviewers:
+ falken@chromium.org, kinuko@chromium.org, michaeln@chromium.org,
nhiroki@chromium.org

[jungkees, 2015-09-11 11:57:01]

Thanks for the peer review, zino@.

OWERs, PTAL

[falken, 2015-10-01 12:31:48]

lgtm

thanks for sticking with this patch!

It's probably overkill but I made a
https://www.chromestatus.com/feature/5897293530136576 for this change.

https://codereview.chromium.org/1339623002/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_context_core.h (right):

https://codereview.chromium.org/1339623002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_context_core.h:189: // seconds (24
hours) have passed since the last update, bypasses the browser
"86400 seconds" seems like trivia not useful in this function comment. Just 24
hours is good.

[jungkees, 2015-10-02 02:11:18]

Thanks for having created https://www.chromestatus.com/feature/5897293530136576.
In the content, I don't think I have a chromium account yet. If you're giving me
one this time, I'd prefer jungkees as the id instead of jungkee.song. ;)

[falken, 2015-10-02 02:15:24]

On 2015/10/02 02:11:18, jungkees wrote:
> Thanks for having created
https://www.chromestatus.com/feature/5897293530136576.
> In the content, I don't think I have a chromium account yet. If you're giving
me
> one this time, I'd prefer jungkees as the id instead of jungkee.song. ;)

Oh, just a mistake. Revised.

[jungkees, 2015-10-02 06:16:19]

Patchset #2 (id:20001) has been deleted

[jungkees, 2015-10-02 06:19:19]

Addressed the comment.

https://codereview.chromium.org/1339623002/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_context_core.h (right):

https://codereview.chromium.org/1339623002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_context_core.h:189: // seconds (24
hours) have passed since the last update, bypasses the browser
On 2015/10/01 12:31:48, falken wrote:
> "86400 seconds" seems like trivia not useful in this function comment. Just 24
> hours is good.

Done.

[jungkees, 2015-10-03 03:40:19]

This CL has been merged to and landed as part of
https://codereview.chromium.org/1380323002/.