content/browser/service_worker/service_worker_dispatcher_host.cc - Issue 1380323002: Make registration.update() no longer force bypassing the HTTP cache

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host.cc

Issue 1380323002: Make registration.update() no longer force bypassing the HTTP cache (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_context_wrapper.cc ('k') | third_party/WebKit/LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/resources/update-worker.php » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_dispatcher_host.cc

diff --git a/content/browser/service_worker/service_worker_dispatcher_host.cc b/content/browser/service_worker/service_worker_dispatcher_host.cc

index c192d96e37110d5e35316776283d4de9afe29874..a042183870385fae365aa66e76d1a92d2de05e67 100644

--- a/content/browser/service_worker/service_worker_dispatcher_host.cc

+++ b/content/browser/service_worker/service_worker_dispatcher_host.cc

@@ -437,10 +437,8 @@ void ServiceWorkerDispatcherHost::OnUpdateServiceWorker(int thread_id,

return;

}

- // The spec says, "update() pings the server for an updated version of this

- // script without consulting caches", so set |force_bypass_cache| to true.

GetContext()->UpdateServiceWorker(

- registration, true /* force_bypass_cache */,

+ registration, false /* force_bypass_cache */,

false /* skip_script_comparison */, provider_host,

base::Bind(&ServiceWorkerDispatcherHost::UpdateComplete, this, thread_id,

provider_id, request_id));