Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart

Issue 1380253003: Issue 24420. Don't allow renaming in pub packages. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart
diff --git a/pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart b/pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart
index 3f0ee70db868bdcfed263383ff457afd2477bc89..d0b312b4128c3caad8d65c4a74a03195277c6496 100644
--- a/pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart
+++ b/pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart
@@ -582,6 +582,43 @@ main(var a) {
assertPotentialEdits(['test(); // 1', 'test(); // 2']);
}
+ test_createChange_MethodElement_potential_inPubCache() async {
+ String pkgLib = '/.pub-cache/lib.dart';
+ indexUnit(
+ pkgLib,
+ r'''
+processObj(p) {
+ p.test();
+}
+''');
+ indexTestUnit('''
+import '$pkgLib';
+class A {
+ test() {}
+}
+main(var a) {
+ a.test();
+}
+''');
+ // configure refactoring
+ createRenameRefactoringAtString('test() {}');
+ expect(refactoring.refactoringName, 'Rename Method');
+ expect(refactoring.oldName, 'test');
+ refactoring.newName = 'newName';
+ // validate change
+ await assertSuccessfulRefactoring('''
+import '/.pub-cache/lib.dart';
+class A {
+ newName() {}
+}
+main(var a) {
+ a.newName();
+}
+''');
+ SourceFileEdit fileEdit = refactoringChange.getFileEdit(pkgLib);
+ expect(fileEdit, isNull);
+ }
+
test_createChange_MethodElement_potential_private_otherLibrary() async {
indexUnit(
'/lib.dart',

Powered by Google App Engine
This is Rietveld 408576698