Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1080)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 137993009: Remove more non-aura windows code. (Closed)

Created:
6 years, 11 months ago by jam
Modified:
6 years, 11 months ago
Reviewers:
sky, scottmg
CC:
chromium-reviews, asanka, yoshiki+watch_chromium.org, dcheng, dmazzoni+watch_chromium.org, benjhayden+dwatch_chromium.org, Ilya Sherman, miu+watch_chromium.org, extensions-reviews_chromium.org, benquan, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, chromium-apps-reviews_chromium.org, jennb, dyu1, jianli, yuzo+watch_chromium.org, ben+views_chromium.org, rouslan+autofillwatch_chromium.org, plundblad+watch_chromium.org, tfarina, Dmitry Titov, aboxhall+watch_chromium.org, robertshield, Dane Wallinga, dtseng+watch_chromium.org, estade+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 9

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : renable the disabled tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -964 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/automation/automation_provider.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/download/drag_download_item_views.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_apitest.cc View 1 2 3 4 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/notifications/balloon.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_window.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/accessibility/accessibility_event_router_views_unittest.cc View 4 chunks +3 lines, -17 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 4 chunks +0 lines, -51 lines 0 comments Download
M chrome/browser/ui/views/hung_renderer_view.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/keyboard_access_browsertest.cc View 1 2 3 4 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/panels/panel_view_browsertest.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/sad_tab_view.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc View 1 2 3 5 chunks +3 lines, -19 lines 0 comments Download
D chrome/browser/ui/views/tab_contents/web_drag_bookmark_handler_win.h View 1 2 3 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/ui/views/tab_contents/web_drag_bookmark_handler_win.cc View 1 2 3 1 chunk +0 lines, -117 lines 0 comments Download
M chrome/browser/ui/views/tabs/dragged_tab_view.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.h View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 4 chunks +1 line, -43 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 3 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/ui/views/task_manager_view.cc View 4 chunks +0 lines, -67 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/automation/proxy_launcher.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/test/base/view_event_test_base.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M content/browser/renderer_host/input/touch_input_browsertest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/content_shell.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/browser/web_contents_delegate.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/browser/web_drag_dest_delegate.h View 3 chunks +0 lines, -16 lines 0 comments Download
M content/shell/browser/shell.h View 3 chunks +3 lines, -11 lines 0 comments Download
M content/shell/browser/shell.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/shell/browser/shell_download_manager_delegate.cc View 2 chunks +8 lines, -2 lines 0 comments Download
D content/shell/browser/shell_win.cc View 1 chunk +0 lines, -285 lines 0 comments Download
M content/shell/browser/webkit_test_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/focus/focus_manager.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M ui/views/mouse_watcher.cc View 2 chunks +0 lines, -85 lines 0 comments Download
M ui/views/test/widget_test.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M webkit/common/cursors/webcursor_unittest.cc View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jam
sky: ui/ scottmg: the rest
6 years, 11 months ago (2014-01-14 20:54:04 UTC) #1
scottmg
https://codereview.chromium.org/137993009/diff/210001/chrome/browser/extensions/extension_tabs_apitest.cc File chrome/browser/extensions/extension_tabs_apitest.cc (left): https://codereview.chromium.org/137993009/diff/210001/chrome/browser/extensions/extension_tabs_apitest.cc#oldcode231 chrome/browser/extensions/extension_tabs_apitest.cc:231: IN_PROC_BROWSER_TEST_F(ExtensionApiTest, FocusWindowDoesNotUnmaximize) { does this not make sense, or ...
6 years, 11 months ago (2014-01-14 21:12:36 UTC) #2
sky
ui LGTM
6 years, 11 months ago (2014-01-14 21:46:06 UTC) #3
jam
https://codereview.chromium.org/137993009/diff/210001/chrome/browser/extensions/extension_tabs_apitest.cc File chrome/browser/extensions/extension_tabs_apitest.cc (left): https://codereview.chromium.org/137993009/diff/210001/chrome/browser/extensions/extension_tabs_apitest.cc#oldcode231 chrome/browser/extensions/extension_tabs_apitest.cc:231: IN_PROC_BROWSER_TEST_F(ExtensionApiTest, FocusWindowDoesNotUnmaximize) { On 2014/01/14 21:12:37, scottmg wrote: > ...
6 years, 11 months ago (2014-01-14 21:54:31 UTC) #4
scottmg
lgtm with the first change https://codereview.chromium.org/137993009/diff/210001/chrome/browser/ui/views/keyboard_access_browsertest.cc File chrome/browser/ui/views/keyboard_access_browsertest.cc (left): https://codereview.chromium.org/137993009/diff/210001/chrome/browser/ui/views/keyboard_access_browsertest.cc#oldcode377 chrome/browser/ui/views/keyboard_access_browsertest.cc:377: #if !defined(OS_WIN) && defined(USE_AURA) ...
6 years, 11 months ago (2014-01-14 22:00:23 UTC) #5
jam
6 years, 11 months ago (2014-01-14 22:24:11 UTC) #6 
https://codereview.chromium.org/137993009/diff/210001/chrome/browser/ui/views...
File chrome/browser/ui/views/keyboard_access_browsertest.cc (left):

https://codereview.chromium.org/137993009/diff/210001/chrome/browser/ui/views...
chrome/browser/ui/views/keyboard_access_browsertest.cc:377: #if !defined(OS_WIN)
&& defined(USE_AURA)
On 2014/01/14 22:00:24, scottmg wrote:
> this one is !WIN && AURA, so probably leave that?

Done.

Powered by Google App Engine
This is Rietveld 408576698