Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Unified Diff: chrome/browser/ui/views/sad_tab_view.cc

Issue 137993009: Remove more non-aura windows code. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: renable the disabled tests Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/sad_tab_view.cc
===================================================================
--- chrome/browser/ui/views/sad_tab_view.cc (revision 244775)
+++ chrome/browser/ui/views/sad_tab_view.cc (working copy)
@@ -236,15 +236,6 @@
// TODO(avi): This is a cheat. Can this be made cleaner?
sad_tab_params.parent = web_contents_->GetView()->GetNativeView();
-#if defined(OS_WIN) && !defined(USE_AURA)
- // Crash data indicates we can get here when the parent is no longer valid.
- // Attempting to create a child window with a bogus parent crashes. So, we
- // don't show a sad tab in this case in hopes the tab is in the process of
- // shutting down.
- if (!IsWindow(sad_tab_params.parent))
- return;
-#endif
-
set_owned_by_client();
views::Widget* sad_tab = new views::Widget;

Powered by Google App Engine
This is Rietveld 408576698