Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 // This functionality currently works on Windows and on Linux when | 5 // This functionality currently works on Windows and on Linux when |
| 6 // toolkit_views is defined (i.e. for Chrome OS). It's not needed | 6 // toolkit_views is defined (i.e. for Chrome OS). It's not needed |
| 7 // on the Mac, and it's not yet implemented on Linux. | 7 // on the Mac, and it's not yet implemented on Linux. |
| 8 | 8 |
| 9 #include "base/memory/weak_ptr.h" | 9 #include "base/memory/weak_ptr.h" |
| 10 #include "base/message_loop/message_loop.h" | 10 #include "base/message_loop/message_loop.h" |
| (...skipping 345 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 356 #if defined(OS_WIN) | 356 #if defined(OS_WIN) |
| 357 #define MAYBE_TestShiftAltMenuKeyboardAccess DISABLED_TestShiftAltMenuKeyboardAc cess | 357 #define MAYBE_TestShiftAltMenuKeyboardAccess DISABLED_TestShiftAltMenuKeyboardAc cess |
| 358 #else | 358 #else |
| 359 #define MAYBE_TestShiftAltMenuKeyboardAccess TestShiftAltMenuKeyboardAccess | 359 #define MAYBE_TestShiftAltMenuKeyboardAccess TestShiftAltMenuKeyboardAccess |
| 360 #endif | 360 #endif |
| 361 IN_PROC_BROWSER_TEST_F(KeyboardAccessTest, | 361 IN_PROC_BROWSER_TEST_F(KeyboardAccessTest, |
| 362 MAYBE_TestShiftAltMenuKeyboardAccess) { | 362 MAYBE_TestShiftAltMenuKeyboardAccess) { |
| 363 TestMenuKeyboardAccess(true, true, false); | 363 TestMenuKeyboardAccess(true, true, false); |
| 364 } | 364 } |
| 365 | 365 |
| 366 #if defined(OS_WIN) && !defined(USE_AURA) | 366 #if defined(OS_WIN) |
| 367 IN_PROC_BROWSER_TEST_F(KeyboardAccessTest, | 367 IN_PROC_BROWSER_TEST_F(KeyboardAccessTest, |
|
scottmg
2014/01/14 21:12:37
these work on aura now?
jam
2014/01/14 21:54:32
oops, I meant to leave these disabled but still in
| |
| 368 TestAltMenuKeyboardAccessFocusOmnibox) { | 368 TestAltMenuKeyboardAccessFocusOmnibox) { |
| 369 TestMenuKeyboardAccess(true, false, true); | 369 TestMenuKeyboardAccess(true, false, true); |
| 370 } | 370 } |
| 371 | 371 |
| 372 IN_PROC_BROWSER_TEST_F(KeyboardAccessTest, TestSystemMenuWithKeyboard) { | 372 IN_PROC_BROWSER_TEST_F(KeyboardAccessTest, TestSystemMenuWithKeyboard) { |
| 373 TestSystemMenuWithKeyboard(); | 373 TestSystemMenuWithKeyboard(); |
| 374 } | 374 } |
| 375 #endif | 375 #endif |
| 376 | 376 |
| 377 #if !defined(OS_WIN) && defined(USE_AURA) | 377 #if !defined(OS_WIN) |
|
scottmg
2014/01/14 22:00:24
this one is !WIN && AURA, so probably leave that?
jam
2014/01/14 22:24:12
Done.
| |
| 378 IN_PROC_BROWSER_TEST_F(KeyboardAccessTest, TestMenuKeyboardOpenDismiss) { | 378 IN_PROC_BROWSER_TEST_F(KeyboardAccessTest, TestMenuKeyboardOpenDismiss) { |
| 379 TestMenuKeyboardAccessAndDismiss(); | 379 TestMenuKeyboardAccessAndDismiss(); |
| 380 } | 380 } |
| 381 #endif | 381 #endif |
| 382 | 382 |
| 383 // Test that JavaScript cannot intercept reserved keyboard accelerators like | 383 // Test that JavaScript cannot intercept reserved keyboard accelerators like |
| 384 // ctrl-t to open a new tab or ctrl-f4 to close a tab. | 384 // ctrl-t to open a new tab or ctrl-f4 to close a tab. |
| 385 // TODO(isherman): This test times out on ChromeOS. We should merge it with | 385 // TODO(isherman): This test times out on ChromeOS. We should merge it with |
| 386 // BrowserKeyEventsTest.ReservedAccelerators, but just disable for now. | 386 // BrowserKeyEventsTest.ReservedAccelerators, but just disable for now. |
| 387 // If this flakes, use http://crbug.com/62311. | 387 // If this flakes, use http://crbug.com/62311. |
| (...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 435 browser(), ui::VKEY_BROWSER_FORWARD, false, false, false, false)); | 435 browser(), ui::VKEY_BROWSER_FORWARD, false, false, false, false)); |
| 436 | 436 |
| 437 base::string16 after_forward; | 437 base::string16 after_forward; |
| 438 ASSERT_TRUE(ui_test_utils::GetCurrentTabTitle(browser(), &after_forward)); | 438 ASSERT_TRUE(ui_test_utils::GetCurrentTabTitle(browser(), &after_forward)); |
| 439 | 439 |
| 440 EXPECT_EQ(before_back, after_forward); | 440 EXPECT_EQ(before_back, after_forward); |
| 441 } | 441 } |
| 442 #endif | 442 #endif |
| 443 | 443 |
| 444 } // namespace | 444 } // namespace |
| OLD | NEW |