Use chromium revision instead of blink svn revision when rebaselining layout tests.

Use chromium commit position instead of blink svn revision when rebaselining layout tests.

+ Remove svn_revision api from scm tools.
+ Nuke all svn related logic in git tool and rebaseline tools.
+ No longer write 'blink_revision' to layout test results. Instead, always populate 'chromium_revision'.
+ Remove support for multiple repositories from port.
+ Link to patch in chromium.googlesource.com in auto-rebaseline git commits.
+ Fail hard when results for a builder are not available (undo of http://crrev.com/1192773002).

BUG=535351, 535354, 502141, 535349
Committed: https://crrev.com/1d5ab015349280e37b127d9151a18899eb57597a
Cr-Commit-Position: refs/heads/master@{#351722}

[joelo, 2015-09-29 04:39:17]

joelo@chromium.org changed reviewers:
+ dpranke@chromium.org, jsbell@chromium.org, ojan@chromium.org

[joelo, 2015-09-29 04:39:17]

ptal :)

[joelo, 2015-09-29 04:40:08]

The CQ bit was checked by joelo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-29 04:40:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1379493002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1379493002/1

[commit-bot: I haz the power, 2015-09-29 05:34:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-29 05:34:21]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Dirk Pranke, 2015-09-29 17:39:23]

This mostly looks fine, but I'd like one minor change.

Ojan might want to review this as well.

https://codereview.chromium.org/1379493002/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py
(right):

https://codereview.chromium.org/1379493002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py:337:
for (name, path) in port_obj.repository_paths():
I think this line means that we'll end up calling scm.chromium_revision() twice
now.

Can you change repository_paths() to be up to date as part of this patch?

[ojan, 2015-09-29 21:31:54]

https://codereview.chromium.org/1379493002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py
(right):

https://codereview.chromium.org/1379493002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py:189: def
_chromium_revision_from_git_commit_log(self, git_log):
nit: _commit_position_from_git_log

https://codereview.chromium.org/1379493002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py:195: def
chromium_revision(self, path):
s/chromium_revision/commit_position/

https://codereview.chromium.org/1379493002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py:233: def
chromium_revision_from_git_commit(self, git_commit):
s/chromium_revision_*/commit_position_*

https://codereview.chromium.org/1379493002/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py
(right):

https://codereview.chromium.org/1379493002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py:342:
results['chromium_revision'] = rev
The old version of this code was correct. You should either:

1. get rid of the support for multiple repositories (i.e. instead of
repository_paths on port, you'd have repository_path)

or

2. Leave this using name.lower().

Up to you which one you do. #1 would require modifying perftestrunner.py as
well.

[joelo, 2015-09-30 09:46:32]

thanks, ptal

https://codereview.chromium.org/1379493002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py
(right):

https://codereview.chromium.org/1379493002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py:189: def
_chromium_revision_from_git_commit_log(self, git_log):
On 2015/09/29 21:31:54, ojan wrote:
> nit: _commit_position_from_git_log

Done.

https://codereview.chromium.org/1379493002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py:195: def
chromium_revision(self, path):
On 2015/09/29 21:31:54, ojan wrote:
> s/chromium_revision/commit_position/

Done.

https://codereview.chromium.org/1379493002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py:233: def
chromium_revision_from_git_commit(self, git_commit):
On 2015/09/29 21:31:54, ojan wrote:
> s/chromium_revision_*/commit_position_*

Done.

https://codereview.chromium.org/1379493002/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py
(right):

https://codereview.chromium.org/1379493002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py:337:
for (name, path) in port_obj.repository_paths():
On 2015/09/29 17:39:23, Dirk Pranke wrote:
> I think this line means that we'll end up calling scm.chromium_revision()
twice
> now.
> 
> Can you change repository_paths() to be up to date as part of this patch?

Good point. Done.

https://codereview.chromium.org/1379493002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py:342:
results['chromium_revision'] = rev
On 2015/09/29 21:31:54, ojan wrote:
> The old version of this code was correct. You should either:
> 
> 1. get rid of the support for multiple repositories (i.e. instead of
> repository_paths on port, you'd have repository_path)
> 
> or
> 
> 2. Leave this using name.lower().
> 
> Up to you which one you do. #1 would require modifying perftestrunner.py as
> well.

Done. Went with #1, less confusing since we no longer have a blink repo.

[joelo, 2015-09-30 09:48:28]

The CQ bit was checked by joelo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-30 09:48:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1379493002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1379493002/20001

[commit-bot: I haz the power, 2015-09-30 10:39:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-30 10:39:45]

Dry run: This issue passed the CQ dry run.

[ojan, 2015-10-01 04:55:10]

The CQ bit was checked by ojan@chromium.org

[ojan, 2015-10-01 04:55:11]

lgtm

[commit-bot: I haz the power, 2015-10-01 04:55:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1379493002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1379493002/20001

[commit-bot: I haz the power, 2015-10-01 05:01:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-01 05:02:23]

Patchset 2 (id:??) landed as
https://crrev.com/1d5ab015349280e37b127d9151a18899eb57597a
Cr-Commit-Position: refs/heads/master@{#351722}