third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py - Issue 1379493002: Use chromium revision instead of blink svn revision when rebaselining layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py

Issue 1379493002: Use chromium revision instead of blink svn revision when rebaselining layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove multiple repo support Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py b/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py

index ba0f3b3bfc3ca49551d1d668dd635f1754be4caf..f35388d9f5b9872f2aa30fb0170310db1b426863 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py

@@ -262,10 +262,10 @@ class PerfTestsRunner(object):

def _generate_results_dict(self, timestamp, description, platform, builder_name, build_number):

revisions = {}

- for (name, path) in self._port.repository_paths():

- scm = SCMDetector(self._host.filesystem, self._host.executive).detect_scm_system(path) or self._host.scm()

- revision = scm.svn_revision(path)

- revisions[name] = {'revision': revision, 'timestamp': scm.timestamp_of_revision(path, revision)}

+ path = self._port.repository_path()

+ scm = SCMDetector(self._host.filesystem, self._host.executive).detect_scm_system(path) or self._host.scm()

+ revision = scm.commit_position(path)

+ revisions['chromium'] = {'revision': revision, 'timestamp': scm.timestamp_of_revision(path, revision)}

meta_info = {

'description': description,