third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py - Issue 1379493002: Use chromium revision instead of blink svn revision when rebaselining layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py

Issue 1379493002: Use chromium revision instead of blink svn revision when rebaselining layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove multiple repo support Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py

index a7760d23d52b59c9602b67702dc6be0404598a51..5c94c2faf672c119ae1918b8469e4e850d792aee 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py

@@ -86,7 +86,7 @@ class LayoutTestResultsTest(unittest.TestCase):

"has_pretty_patch": false,

"fixable": 1220,

"num_flaky": 0,

- "blink_revision": "1234",

+ "chromium_revision": "1234",

"has_wdiff": false

});"""

@@ -98,8 +98,8 @@ class LayoutTestResultsTest(unittest.TestCase):

self.assertTrue(LayoutTestResults.results_from_string('ADD_RESULTS({"tests":{},"interrupted":true});').run_was_interrupted())

self.assertFalse(LayoutTestResults.results_from_string('ADD_RESULTS({"tests":{},"interrupted":false});').run_was_interrupted())

- def test_blink_revision(self):

- self.assertEqual(LayoutTestResults.results_from_string(self.example_full_results_json).blink_revision(), 1234)

+ def test_chromium_revision(self):

+ self.assertEqual(LayoutTestResults.results_from_string(self.example_full_results_json).chromium_revision(), 1234)

def test_actual_results(self):

results = LayoutTestResults.results_from_string(self.example_full_results_json)