Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1379433005: Increasing the Breakpad stack walker max scan limit from 30 to 40. (Closed)

Created:
5 years, 2 months ago by ivanpe
Modified:
5 years, 2 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Increasing the Breakpad stack walker max scan limit from 30 to 40. Chrome started hitting some crashes in v8 jitted code which happens to be non ABI compliant and debuggers (including WinDBG) are unable to produce meaningful stack traces. The Breakpad stack walker has some builtin heuristics to deal with such cases. More specifically, when unable to find a good parent frame, it scans the raw stack to find a suitable parent frame. The max scan size was set at 30 pointers which was (apparently) not enough to recover in this case. I'm increasing it to 40 pointers. I confirmed that at 34 pointers it was able to recover however I'm setting it to 40 in order to it some slack. I needed to update two unittests which were expecting the previous scan limit. BUG= R=mark@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/84d37160a74e0ce627a6fedf3395a7480450f4c1

Patch Set 1 #

Patch Set 2 : Updating a comment in a test file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/processor/stackwalker.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/stackwalker_arm64_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/stackwalker_arm_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/processor/stackwalker_x86_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ivanpe
5 years, 2 months ago (2015-10-03 01:50:57 UTC) #2
Mark Mentovai
LGTM
5 years, 2 months ago (2015-10-05 15:47:43 UTC) #3
ivanpe
5 years, 2 months ago (2015-10-05 18:35:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
84d37160a74e0ce627a6fedf3395a7480450f4c1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698