src/processor/stackwalker_arm_unittest.cc - Issue 1379433005: Increasing the Breakpad stack walker max scan limit from 30 to 40.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/processor/stackwalker_arm_unittest.cc

Issue 1379433005: Increasing the Breakpad stack walker max scan limit from 30 to 40. (Closed) Base URL: https://chromium.googlesource.com/breakpad/breakpad.git@master

Patch Set: Updating a comment in a test file. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/processor/stackwalker_arm_unittest.cc

diff --git a/src/processor/stackwalker_arm_unittest.cc b/src/processor/stackwalker_arm_unittest.cc

index c73322e6b6d895843dab83eca728b389226641d2..8a0fd5e95b15d8b4fab3c390fba831076b9f4c6a 100644

--- a/src/processor/stackwalker_arm_unittest.cc

+++ b/src/processor/stackwalker_arm_unittest.cc

@@ -370,7 +370,7 @@ TEST_F(GetCallerFrame, ScanFirstFrame) {

.D32(0xF0000000) // more junk

.D32(0x0000000D)

- .Append(96, 0) // more space

+ .Append(136, 0) // more space

.D32(return_address2) // actual return address

// (won't be found)

« no previous file with comments | « src/processor/stackwalker_arm64_unittest.cc ('k') | src/processor/stackwalker_x86_unittest.cc » ('j') | no next file with comments »